Repository navigation
Conversation
d98b06b to
861eae8
Compare
|
Rebased onto current main as one signed-off commit (861eae8), which clears DCO. The earlier test failures came from the Windows cap: two download tests still expected a v3.4.5 or default-version Windows URL. Lifecycle stopped shipping Windows binaries after v0.20.5 (v0.21.x only has Linux and FreeBSD assets), so those tests now expect the capped v0.20.5 URL. I also added a FreeBSD arm64 download test. |
|
The red |
- Add FreeBSD support with amd64 and arm64 architectures - Cap Windows lifecycle version at v0.20.5, the last release with a Windows binary, with a warning - Replace the SupportedLinuxArchitecture check with per-OS arch mappers - Map the amd64 alias per OS (x86-64 on Linux/Windows, amd64 on FreeBSD) - Update the Windows download tests to the capped URL and add a FreeBSD download test Fixes buildpacks#2546 Signed-off-by: Matt Van Horn <mvanhorn@gmail.com>
861eae8 to
0bc9343
Compare
Summary
Fixes
uriFromLifecycleVersionto correctly handle all OS/architecture combinations that the lifecycle project publishes binaries for.Why this matters
Three issues existed in the URL builder (#2546):
amd64vsx86-64) differed by OS but were only handled for LinuxChanges
pkg/client/create_builder.go: RewroteuriFromLifecycleVersionwith aswitchon OS. AddedlinuxArch,freebsdArch, andwindowsArchhelpers that map input architectures to the correct binary suffix per OS. Windows now caps at v0.20.5 with a deprecation warning.internal/builder/lifecycle.go: AddedSupportedFreeBSDArchitecturefor consistency with the existingSupportedLinuxArchitecture.Architecture mapping per OS
Fixes #2546
This contribution was developed with AI assistance (Claude Code).