Skip to content

deps: bump the lifecycle library to v0.21.29 and drop docker/docker - #2745

Merged
jjbustamante merged 6 commits into
mainfrom
deps/lifecycle-lib-0.21.29
Nov 15, 2026
Merged

jjbustamante merged 6 commits into
mainfrom
deps/lifecycle-lib-0.21.29

Conversation

@jjbustamante

@jjbustamante jjbustamante commented Nov 15, 2026 •

Copy link
Copy Markdown
Member

Summary

Bumps the lifecycle library from v0.21.0 to v0.21.29. lifecycle stopped depending on github.com/docker/docker in v0.21.15, and #2667 removed pack's own import of it, so this takes the module out of pack entirely.

  • lifecycle v0.21.29 and imgutil 3665d0bdb3f4, which includes local: never send a partial platform to the daemon imgutil#312. The newer imgutil asks a platform-aware daemon for a specific platform, and without No explicit error if packaged CNB has no version #312 every build using a buildpack package image failed with both OS and Architecture must be provided. That was the daemon-rebase failure that held these dependencies back.
  • Go 1.27.4, required by lifecycle v0.21.29 (go.mod, Dockerfile, fake-lifecycle fixture).
  • golangci-lint v2.15.0, since v2.0.2 cannot load a Go 1.27 module. Five small fixes for the newer linters, plus an exclusion for warnings about pack's own deprecated fields, which pack keeps for backwards compatibility.
  • .grype.yaml deleted. Every entry was for docker/docker, docker/distribution, buildkit, docker/cli, x/crypto/openpgp or protobuf, which are now gone or fixed. The binary and the image built from this branch scan clean with no ignores.

Moves along with lifecycle: moby client 0.6.2, go-containerregistry 0.22.1, buildkit 0.34.2, docker/cli 29.9.3, and the unmaintained chrismellard/docker-credential-acr-env is replaced by osscontainertools/docker-credential-acr.

Visible change: spf13/pflag 1.1.0, which lifecycle requires, prints every boolean flag in --help as --flag[=true|false]. pflag has no option to turn this off.

Output

Before

$ govulncheck ./...
Your code is affected by 3 vulnerabilities from 2 modules.
GO-2026-6255 (buildkit) GO-2026-4887 GO-2026-4883 (docker/docker)

$ pack build --help
      --publish                                  Publish the application image directly to ...

After

$ govulncheck ./...
No vulnerabilities found.

$ pack build --help
      --publish[=true|false]                     Publish the application image directly to ...

make verify, make unit and the full acceptance suite pass (95 passed, 0 failed, 11 skipped, Docker 29.9.3, including daemon rebase).

Documentation

  • Should this change be documented?
    • Yes, see #___
    • No

The CLI reference in buildpacks/docs is generated from pack's help output, so it will pick up the [=true|false] change on regeneration.

Related

Resolves #2470
Resolves #2748
Resolves #2749

@jjbustamante
jjbustamante requested review from a team as code owners November 15, 2026 00:20
@jjbustamante jjbustamante added the dependencies Pull requests that update a dependency file label Nov 15, 2026
@github-actions github-actions Bot added this to the 0.41.0 milestone Nov 15, 2026
@github-actions github-actions Bot added type/enhancement Issue that requests a new feature or improvement. type/chore Issue that requests non-user facing changes. labels Nov 15, 2026
jjbustamante and others added 3 commits November 14, 2026 19:24
v2.0.2 cannot load a Go 1.27 module. The newer staticcheck and govet
flag five spots, fixed here (fmt.Fprintf, reflect.Pointer), and nine
uses of pack's own deprecated fields, which pack keeps for backwards
compatibility; those are excluded by package path so deprecations from
other modules are still reported.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Signed-off-by: Juan Bustamante <bustamantejj@gmail.com>
lifecycle stopped depending on github.com/docker/docker in v0.21.15, so
this removes the module from pack entirely (pack's own import of it was
removed by vendoring volume/mounts). It also drops the unmaintained
chrismellard/docker-credential-acr-env helper.

- Go 1.27.4, required by lifecycle v0.21.29 (go.mod, Dockerfile).
- spf13/pflag 1.1.0, required by lifecycle, prints boolean flags as
  `--flag[=true|false]` in help output; update the stack help fixture.
- The fake-lifecycle test module moves to the same lifecycle version.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Signed-off-by: Juan Bustamante <bustamantejj@gmail.com>
imgutil 3665d0bdb3f4 no longer sends a partial platform to the daemon,
which failed every build that used a buildpack package image
(buildpacks/imgutil#312).

Every entry in .grype.yaml was for a module that is now gone or fixed:
docker/docker, docker/distribution, buildkit (now v0.34.2), docker/cli,
x/crypto/openpgp and protobuf. The binary and the published image scan
clean without any ignores.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Signed-off-by: Juan Bustamante <bustamantejj@gmail.com>
@jjbustamante
jjbustamante force-pushed the deps/lifecycle-lib-0.21.29 branch from 18b860e to fc6cf1a Compare November 15, 2026 00:31
jjbustamante and others added 3 commits November 14, 2026 19:44
go-winio v0.6.4, pulled in by the lifecycle bump, deprecates
ErrPipeListenerClosed and ErrFileClosed in favour of net.ErrClosed and
os.ErrClosed, which they are now aliases of. staticcheck flags both on
Windows. ErrPipeListenerClosed duplicated the net.ErrClosed check.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Signed-off-by: Juan Bustamante <bustamantejj@gmail.com>
The Makefile installs golangci-lint with `go install ...@<version>`,
which ignores tools/go.mod, so pinning it there too only added a second
version to keep in sync (they had drifted: v2.0.2 in the Makefile,
v2.0.2+ in go.mod) and pulled the linter's dependency tree into the
module license scans. Three of those dependencies are GPL-3.0
(golangci-lint, nonamedreturns, structtags); none are linked into pack.

The Makefile's version is now the only pin. Dependabot never covered
tools/, so this does not change how the linter is bumped.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Signed-off-by: Juan Bustamante <bustamantejj@gmail.com>
moby/moby/client v0.6.2, pulled in by the lifecycle bump, adds
ImageAttestations to APIClient.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Signed-off-by: Juan Bustamante <bustamantejj@gmail.com>
@jjbustamante
jjbustamante merged commit 794ce1a into main Nov 15, 2026
16 checks passed
@jjbustamante
jjbustamante deleted the deps/lifecycle-lib-0.21.29 branch November 15, 2026 01:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

dependencies Pull requests that update a dependency file type/chore Issue that requests non-user facing changes. type/enhancement Issue that requests a new feature or improvement.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

CVE(s) found Upgrade buildpacks/pack to go1.27.4 Address breaking changes to go packages in docker 29.0.0 release

1 participant