Repository navigation
deps: bump the lifecycle library to v0.21.29 and drop docker/docker - #2745
Merged
Merged
Conversation
v2.0.2 cannot load a Go 1.27 module. The newer staticcheck and govet flag five spots, fixed here (fmt.Fprintf, reflect.Pointer), and nine uses of pack's own deprecated fields, which pack keeps for backwards compatibility; those are excluded by package path so deprecations from other modules are still reported. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Signed-off-by: Juan Bustamante <bustamantejj@gmail.com>
lifecycle stopped depending on github.com/docker/docker in v0.21.15, so this removes the module from pack entirely (pack's own import of it was removed by vendoring volume/mounts). It also drops the unmaintained chrismellard/docker-credential-acr-env helper. - Go 1.27.4, required by lifecycle v0.21.29 (go.mod, Dockerfile). - spf13/pflag 1.1.0, required by lifecycle, prints boolean flags as `--flag[=true|false]` in help output; update the stack help fixture. - The fake-lifecycle test module moves to the same lifecycle version. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Signed-off-by: Juan Bustamante <bustamantejj@gmail.com>
imgutil 3665d0bdb3f4 no longer sends a partial platform to the daemon, which failed every build that used a buildpack package image (buildpacks/imgutil#312). Every entry in .grype.yaml was for a module that is now gone or fixed: docker/docker, docker/distribution, buildkit (now v0.34.2), docker/cli, x/crypto/openpgp and protobuf. The binary and the published image scan clean without any ignores. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Signed-off-by: Juan Bustamante <bustamantejj@gmail.com>
jjbustamante
force-pushed
the
deps/lifecycle-lib-0.21.29
branch
from
November 15, 2026 00:31
18b860e to
fc6cf1a
Compare
go-winio v0.6.4, pulled in by the lifecycle bump, deprecates ErrPipeListenerClosed and ErrFileClosed in favour of net.ErrClosed and os.ErrClosed, which they are now aliases of. staticcheck flags both on Windows. ErrPipeListenerClosed duplicated the net.ErrClosed check. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Signed-off-by: Juan Bustamante <bustamantejj@gmail.com>
The Makefile installs golangci-lint with `go install ...@<version>`, which ignores tools/go.mod, so pinning it there too only added a second version to keep in sync (they had drifted: v2.0.2 in the Makefile, v2.0.2+ in go.mod) and pulled the linter's dependency tree into the module license scans. Three of those dependencies are GPL-3.0 (golangci-lint, nonamedreturns, structtags); none are linked into pack. The Makefile's version is now the only pin. Dependabot never covered tools/, so this does not change how the linter is bumped. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Signed-off-by: Juan Bustamante <bustamantejj@gmail.com>
moby/moby/client v0.6.2, pulled in by the lifecycle bump, adds ImageAttestations to APIClient. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Signed-off-by: Juan Bustamante <bustamantejj@gmail.com>
1 of 2 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Bumps the lifecycle library from v0.21.0 to v0.21.29. lifecycle stopped depending on
github.com/docker/dockerin v0.21.15, and #2667 removed pack's own import of it, so this takes the module out of pack entirely.3665d0bdb3f4, which includes local: never send a partial platform to the daemon imgutil#312. The newer imgutil asks a platform-aware daemon for a specific platform, and without No explicit error if packaged CNB has no version #312 every build using a buildpack package image failed withboth OS and Architecture must be provided. That was the daemon-rebase failure that held these dependencies back.go.mod,Dockerfile, fake-lifecycle fixture)..grype.yamldeleted. Every entry was for docker/docker, docker/distribution, buildkit, docker/cli, x/crypto/openpgp or protobuf, which are now gone or fixed. The binary and the image built from this branch scan clean with no ignores.Moves along with lifecycle: moby client 0.6.2, go-containerregistry 0.22.1, buildkit 0.34.2, docker/cli 29.9.3, and the unmaintained
chrismellard/docker-credential-acr-envis replaced byosscontainertools/docker-credential-acr.Visible change: spf13/pflag 1.1.0, which lifecycle requires, prints every boolean flag in
--helpas--flag[=true|false]. pflag has no option to turn this off.Output
Before
After
make verify,make unitand the full acceptance suite pass (95 passed, 0 failed, 11 skipped, Docker 29.9.3, including daemon rebase).Documentation
The CLI reference in buildpacks/docs is generated from pack's help output, so it will pick up the
[=true|false]change on regeneration.Related
Resolves #2470
Resolves #2748
Resolves #2749