Skip to content

Adding --show option for CI/CD processes to consume#209

Open
twcurrie wants to merge 2 commits into
c4urself:masterfrom
twcurrie:tcurrie/showOption
Open

Adding --show option for CI/CD processes to consume#209
twcurrie wants to merge 2 commits into
c4urself:masterfrom
twcurrie:tcurrie/showOption

Conversation

@twcurrie

@twcurrie twcurrie commented Apr 5, 2021

Copy link
Copy Markdown

Adds --show option referenced in these issues:

I also strongly desire this feature, so I aimed for simplicity and minimal change on this add-on, and tried to match the coding style as best as possible. I defer to the maintainer should they have stronger opinions on implementation 😉 , but I believe there is strong interest in this feature overall.

@florisla

Copy link
Copy Markdown
Collaborator

This is long overdue, thanks for contributing this.

If I find the time, I will review this and include it in the next release.

@clbarnes

Copy link
Copy Markdown
Contributor

Might it be better to use print rather than logging to output the version? That would play nicer with scripting, is simpler, and more expected, as logging writes to stderr and should be used to communicate with the user, where print uses stdout and represents a program's primary output.

@twcurrie

Copy link
Copy Markdown
Author

@clbarnes I don't have a strong opinion on that, but it's a trivial change if desired - @florisla thoughts?

@florisla florisla added this to the Next release milestone Mar 2, 2022
@florisla

florisla commented Mar 2, 2022

Copy link
Copy Markdown
Collaborator

I agree that the --show output should go to stdout.

@florisla florisla self-requested a review March 2, 2022 14:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants