fix: parse sign_tags from config as boolean#281
Open
maimul wants to merge 1 commit into
Open
Conversation
sign_tags = False in .bumpversion.cfg was silently ignored because the boolean parsing loop only covered commit, tag, and dry_run. Adding sign_tags to that loop makes config-file values take effect correctly. Fixes c4urself#269
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Setting
sign_tags = Falsein.bumpversion.cfghas no effect. The boolean-parsing loop in_load_configurationonly coverscommit,tag, anddry_run, sosign_tagsis never read from the config file. Users who setsign_tags = Falseto suppress GPG signing still get signing attempts, which fail if no GPG key is configured.Fix
Add
sign_tagsto the boolean-parsing loop (one-line change incli.py):Reproducer
Before this fix,
sign_tagsremainsTrue(the argparse default), so bumpversion attempts GPG signing. After this fix it is correctlyFalse.Fixes #269