feat(CodeSigningPlugin): multiple public keys support#1382
Open
MikitasK wants to merge 11 commits intocallstack:mainfrom
Open
feat(CodeSigningPlugin): multiple public keys support#1382MikitasK wants to merge 11 commits intocallstack:mainfrom
MikitasK wants to merge 11 commits intocallstack:mainfrom
Conversation
|
@MikitasK is attempting to deploy a commit to the Callstack Team on Vercel. A member of the Team first needs to authorize it. |
🦋 Changeset detectedLatest commit: a8b4038 The changes in this PR will be included in the next version bump. This PR includes changesets to release 6 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
bartekkrok
approved these changes
Apr 23, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Closes #826
The PR adds support for passing a per-script
publicKeythroughScriptManagerresolver output, so signed bundles can be verified with a runtime-provided public key instead of only the app-embeddedRepackPublicKey.This solves the multi-team / multi-miniapp use case described in the issue:
RepackPublicKeyImplementation notes:
publicKeystring toScriptLocatorScriptManageron Android and iOSverifyScriptSignature: 'strict' | 'lax' | 'off'behavior intactpublicKeyinvalidates the cached script configTest plan
Test Plan
publicKeyfrom aScriptManagerresolver together withverifyScriptSignature: 'strict'publicKeyallows the signed bundle to load on iOS and AndroidpublicKeyfails verification on iOS and AndroidpublicKeystill uses the existingRepackPublicKeyfallback behaviorRecordings
Android
android.mp4
iOS
ios.mp4
JS side
publicKeyvalidation (both platforms)Screen.Recording.2026-04-22.at.16.08.28.mp4