Skip to content

Make NotInSchema field private - #634

Open
stepancheg wants to merge 1 commit into
capnproto:masterfrom
stepancheg:not-in-schema
Open

stepancheg wants to merge 1 commit into
capnproto:masterfrom
stepancheg:not-in-schema

Conversation

@stepancheg

Copy link
Copy Markdown
Contributor

NotInSchema error can have a cheap enum_name: &'static str field to make error message more helpful, because when we parse files, we usually don't provide detailed information where error comes from. So storing such information would help debugging it.

But that would be a breaking change. So let's break it now.

@stepancheg
stepancheg marked this pull request as draft March 29, 2026 03:21
@codecov

codecov Bot commented Mar 30, 2026

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 0% with 47 lines in your changes missing coverage. Please review.
✅ Project coverage is 50.98%. Comparing base (ab342b3) to head (566bc07).
⚠️ Report is 351 commits behind head on master.

Files with missing lines Patch % Lines
capnp/src/schema_capnp.rs 0.00% 19 Missing ⚠️
capnp-rpc/src/rpc_capnp.rs 0.00% 17 Missing ⚠️
capnp/src/lib.rs 0.00% 7 Missing ⚠️
capnpc/src/codegen.rs 0.00% 2 Missing ⚠️
capnp-rpc/src/rpc.rs 0.00% 1 Missing ⚠️
capnp-rpc/src/rpc_twoparty_capnp.rs 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #634      +/-   ##
==========================================
- Coverage   51.64%   50.98%   -0.66%     
==========================================
  Files          69       71       +2     
  Lines       33735    32506    -1229     
==========================================
- Hits        17422    16574     -848     
+ Misses      16313    15932     -381     

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@stepancheg
stepancheg marked this pull request as ready for review March 30, 2026 00:17

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant