Repository navigation
Add rbdmirror test scenario - #7754
Open
noonedeadpunk wants to merge 4 commits into
Open
noonedeadpunk wants to merge 4 commits into
noonedeadpunk wants to merge 4 commits into
Conversation
Peer adding tasks were run regardlessly of existing mirror configuration which means that result will always return "changed" results, making idempotence test to fail. Now these tasks are being run only if mirroring user does not exist yet for the cluster. Signed-off-by: Dmitriy Rabotyagov <noonedeadpunk@gmail.com>
Mapping .keys() always contain a list of strings. At the same time rbdmirror_to_kill_gid is fetched as an int. When comparison happens, it returns no matches, prematurely passing the post task. Matching it to a string makes servicemap to wait for a positive result before proceeding further. Signed-off-by: Dmitriy Rabotyagov <noonedeadpunk@gmail.com>
rbd-mirror was one of well-tested scenarios in the past. This patch does return back the test, while focusing it only over `dev` path to have a minimal impact on amount of tests that need to run, to save some resources. During side-effect of the test we add a "spare" node as a second mirror, verify the state, and remove that node afterwards. Signed-off-by: Dmitriy Rabotyagov <noonedeadpunk@gmail.com>
As we don't have anything in default scenario per say, but prepare/converge/cleanup playbooks are pretty much the same and shared between scenarios, let's move them under `default` umbrella to avoid creating weird cross-scenario dependencies. Signed-off-by: Dmitriy Rabotyagov <noonedeadpunk@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
rbd-mirror was one of well-tested scenarios in the past.
This patch does return back the test, while focusing it only over
devpath to have a minimal impact on amount of tests that need to run,
to save some resources.
During side-effect of the test we add a "spare" node as a second mirror,
verify the state, and remove that node afterwards.