Issue #922: Improve refresh button positioning#1024
Draft
kush2439p wants to merge 1 commit into
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Root cause
The refresh button's grid data grabbed all excess horizontal space and aligned the button at the far end of that expanded cell. On laptop-sized displays, this could leave the button partially clipped and contribute to horizontal scrolling.
User impact
The refresh action remains fully visible beside the rebuild dropdown at narrower resolutions, including the 1536 x 864 scenario reported in #922.
Validation
git diff --check./mvnw.cmd -pl net.sf.eclipsecs.ui -am verify; dependency download completed, but Tycho stalled while resolving the Eclipse target platform in the sandboxFixes #922