Skip to content

Add channel_->tie() in Connector::connecting() to fix lifetime safety #736

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Louisyoung7 wants to merge 1 commit into
base: master
Choose a base branch
from
+4 −3
Open

Add channel_->tie() in Connector::connecting() to fix lifetime safety #736

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 4 additions & 3 deletions muduo/net/Connector.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -130,10 +130,11 @@ void Connector::connecting(int sockfd)
setState(kConnecting);
assert(!channel_);
channel_.reset(new Channel(loop_, sockfd));
channel_->tie(shared_from_this());
channel_->setWriteCallback(
std::bind(&Connector::handleWrite, this)); // FIXME: unsafe
std::bind(&Connector::handleWrite, this));
channel_->setErrorCallback(
std::bind(&Connector::handleError, this)); // FIXME: unsafe
std::bind(&Connector::handleError, this));

// channel_->tie(shared_from_this()); is not working,
// as channel_ is not managed by shared_ptr
Expand All @@ -146,7 +147,7 @@ int Connector::removeAndResetChannel()
channel_->remove();
int sockfd = channel_->fd();
// Can't reset channel_ here, because we are inside Channel::handleEvent
loop_->queueInLoop(std::bind(&Connector::resetChannel, this)); // FIXME: unsafe
loop_->queueInLoop(std::bind(&Connector::resetChannel, this));
return sockfd;
}

Expand Down