Add YAML verification to Smoke Tests

.squad/agents/fenster/history.md

@@ -129,3 +129,19 @@
 - Designed/implemented/validated 	est/smoke-tests.ps1 (88 cases: 22 specs × 4 wrapper modes), CI job updated with failure-only artifact upload, README documented.
 - Initial denylist: ingram-micro.json (duplicate pub const emissions in unified model generator — follow-up backend work).
 - Decision recorded in decisions.md (2026-04-30 entry). Session-scoped directive: agents use Claude Opus 4.7 for this session only.
+
+### YAML smoke coverage across both layers (2026-05-01T11:50:14.189+02:00)
+
+- `test/smoke-tests.ps1` now discovers `.json`, `.yaml`, and `.yml` fixtures under `openapi/v2.0`, `v3.0`, `v3.1`, and `v3.2`, and writes smoke outputs as `test/output/<version>/<basename>__<format>__<mode>.zig` so JSON/YAML siblings never overwrite each other.
+- The curated harness remains separate: `build.zig` now generates `generated/generated_v2_yaml.zig`, `generated/generated_v3_yaml.zig`, and `generated/generated_v31_yaml.zig`; `generated/compile_generated.zig` and `generated/main.zig` import those YAML artifacts beside the existing JSON ones. `openapi/v3.2` stays JSON-only because there is no checked-in YAML fixture.
+- Broad YAML smoke currently passes with targeted denylist entries for six mode-independent YAML `ParseFailure` fixtures: `openapi/v2.0/petstore-expanded.yaml`, `openapi/v2.0/uber.yaml`, `openapi/v3.0/api-with-examples.yaml`, `openapi/v3.0/bot.paths.yaml`, `openapi/v3.0/petstore-expanded.yaml`, and `openapi/v3.0/uspto.yaml`.
+
+### 2026-05-01T11:50:14.189+02:00 — Scribe closeout
+
+- Scribe merged Fenster's YAML smoke decisions into `decisions.md`: keep the two smoke layers separate, use `<basename>__<format>__<mode>.zig` output names, and allow deterministic parse-phase YAML denylist entries with `Mode = "*"`.
+- The closeout keeps the YAML parser/normalization blocker explicit so backend follow-up can retire those denylist entries intentionally instead of hiding them behind JSON-only behavior.
+
+### 2026-05-01T09:50:14Z — Scribe closeout
+
+- Scribe recorded the YAML smoke release as shipped from commits `ac9ed97`, `e6f07ee`, and `55c260e`, preserving the two-layer split between the broad PowerShell sweep and the curated generated harness.
+- The shared decision log now carries the collision-safe `__<format>__` smoke filename rule and the explicit wildcard denylist policy for deterministic pre-wrapper YAML parse failures.

.squad/agents/juno/history.md

@@ -128,3 +128,17 @@ Users can now provide OpenAPI specs via remote URLs in addition to local file pa
 - Designed/implemented/validated 	est/smoke-tests.ps1 (88 cases: 22 specs × 4 wrapper modes), CI job updated with failure-only artifact upload, README documented.
 - Initial denylist: ingram-micro.json (duplicate pub const emissions in unified model generator — follow-up backend work).
 - Decision recorded in decisions.md (2026-04-30 entry). Session-scoped directive: agents use Claude Opus 4.7 for this session only.
+
+## 2026-05-01T11:50:14.189+02:00 — YAML smoke docs alignment
+- Broad smoke coverage lives in `test/smoke-tests.ps1`; it should treat YAML as first-class input and encode source format in artifact names such as `__json__` / `__yaml__` to avoid sibling collisions.
+- README smoke docs should distinguish the broad PowerShell sweep from the smaller curated sample harness in `build.zig` and `generated/main.zig`; broad discovery must not imply JSON/YAML twin files are required, and the curated harness should call out that `v3.2` is still JSON-only because the repo has no `v3.2` YAML root fixture.
+- Useful review paths for this topic: `README.md`, `test/smoke-tests.ps1`, `build.zig`, `generated/main.zig`, and YAML fixture roots like `openapi/v2.0/petstore.yaml`, `openapi/v3.0/petstore.yaml`, `openapi/v3.1/webhook-example.yaml`, `openapi/v3.0/bot.paths.yaml`.
+
+### 2026-05-01T11:50:14.189+02:00 — Scribe closeout
+
+- Scribe recorded Juno's docs closeout: README now distinguishes the broad JSON+YAML smoke sweep from the curated harness, keeps `v3.2` JSON-only, and the doc work landed as commits `de53aaa` and `8e87cbe`.
+- Closeout notes preserve the `__json__` / `__yaml__` output naming rule in the docs so artifact descriptions stay aligned with the smoke script.
+
+### 2026-05-01T09:50:14Z — Scribe closeout
+
+- Scribe merged Juno's docs guidance into the shared decision log: README smoke docs must separate the broad JSON+YAML sweep from the curated harness, avoid implying JSON/YAML sibling pairs are required, and keep `openapi/v3.2` described as JSON-only today.

.squad/agents/scribe/history.md

@@ -27,3 +27,9 @@ Initial setup complete.
 - Designed/implemented/validated 	est/smoke-tests.ps1 (88 cases: 22 specs × 4 wrapper modes), CI job updated with failure-only artifact upload, README documented.
 - Initial denylist: ingram-micro.json (duplicate pub const emissions in unified model generator — follow-up backend work).
 - Decision recorded in decisions.md (2026-04-30 entry). Session-scoped directive: agents use Claude Opus 4.7 for this session only.
+
+## 2026-05-01T09:50:14Z — YAML smoke scribe closeout
+
+- Pre-check recorded `decisions.md` at 8263 bytes with 4 decision inbox files.
+- Archive gate did not trigger; decisions stayed below 20480 bytes.
+- Merged and deduplicated YAML smoke decisions, deleted processed inbox files, wrote orchestration/session logs, and checked the history summarization gate.

.squad/agents/starkiller/history-archive.md

@@ -0,0 +1,170 @@
+# Starkiller History Archive
+
+## Archived 2026-05-01T09:50:14Z
+
+### PR #46 documentation verification (2026-04-28T23:01:58.137+02:00)
+
+**Verification result:** README and docs now match the current generated runtime shape after a small correction. Static checks compared `README.md` and `docs/index.html` against `src/cli.zig`, `src/generator.zig`, `generated/generated_v2.zig`, `generated/generated_v3.zig`, `generated/generated_v31.zig`, `generated/generated_v32.zig`, `generated/compile_generated.zig`, and `generated/main.zig`.
+
+**Blocked validations:** `zig version`, `zig build run-generate`, `zig build test`, `zig test generated\compile_generated.zig`, and `zig build-exe generated\main.zig -fno-emit-bin` are blocked locally because `C:\Users\chris\AppData\Local\Microsoft\WinGet\Links\zig.exe` fails to start with "No application is associated with the specified file for this operation."
+
+**Docs fixed:** `README.md` had invalid Zig string literals in the generated-code calling example because `\n` escapes had become literal line breaks inside strings. `docs/index.html` now names `ParseErrorResponse` and describes raw/typed SSE plus OpenAI stream helpers consistently with the PR #46 acceptance criteria.
+
+### Input Loader Testing Strategy (2026-03-20)
+
+**Test File:** `src/tests/test_input_loader.zig`
+
+**Hybrid Testing Approach (Per Lando's Architecture):**
+- **Unit tests:** Fast, deterministic, no network dependencies
+  - Mock/error scenarios with unreachable IPs (192.0.2.1 - RFC 5737)
+  - File path validation and error handling
+  - Memory leak detection on all code paths
+- **Integration tests:** Validate real-world HTTP functionality
+  - Marked to skip in development via `SKIP_INTEGRATION_TESTS` env var
+  - Test against public OpenAPI endpoints (petstore3.swagger.io, petstore.swagger.io)
+  - Verify full pipeline: fetch → parse → convert → generate
+
+**Both-Spec Validation:**
+- Every test covers BOTH v2.0 (Swagger) AND v3.0 (OpenAPI)
+- File-based and URL-based loading tested for both versions
+- Side-by-side comparison ensures consistency between file and URL sources
+- Full pipeline tests: load → detect version → parse → validate structure
+
+**HTTP Client API (Zig 0.15.2):**
+- Uses `std.http.Client.request()` API (not `.fetch()`)
+- Pattern: `client.request()` → `sendBodiless()` → `receiveHead()` → `reader.readAlloc()`
+- Proper error handling for: invalid URL, connection failure, 404, timeouts
+- Memory ownership: caller owns returned body, must free with `allocator.free()`
+
+**Memory Management:**
+- All tests use `test_utils.createTestAllocator()` for leak detection
+- Comprehensive `defer` cleanup on all code paths
+- Tests verify no leaks even on error paths
+- Switch statements must handle `.Unsupported` version case
+
+**Edge Cases Covered:**
+- Large file handling (api-with-examples.json ~6KB)
+- Non-existent files and URLs
+- Invalid URL schemes (ftp://, file://)
+- Connection timeouts (unreachable IPs)
+- HTTP 404 responses
+- Malformed URLs
+- Empty response bodies
+
+**Integration Test Design:**
+- Tests skip via environment variable: `SKIP_INTEGRATION_TESTS=1`
+- Real endpoints tested:
+  - `https://petstore3.swagger.io/api/v3/openapi.json` (v3.0)
+  - `https://petstore.swagger.io/v2/swagger.json` (v2.0)
+- Verify network fetch produces same parseable structure as file load
+- Full validation chain ensures end-to-end correctness
+
+**Test Organization:**
+- Logical sections with clear comments
+- Unit tests first (fast feedback)
+- Integration tests last (skip in dev)
+- Each test has descriptive name and focused scope
+- Tests validate both positive and negative cases
+
+### Smoke Test Coverage Design (2026-04-30)
+
+**Task:** Design `test/smoke-tests.ps1` for PR verification — enumerate all specs under `openapi/`, generate code, compile-check each.
+
+**Key findings:**
+
+**Spec inventory:** 22 JSON specs are eligible: 8 in `v2.0/`, 10 in `v3.0/`, 2 in `v3.1/`, 2 in `v3.2/`. Total spec count across all YAML equivalents is ~40 files.
+
+**Skip rules (hard):**
+- All `*.yaml` / `*.yml` — YAML returns `UnsupportedExtension` from `generator.zig`; would produce 100% false failures.
+- `openapi/json-schema/**` — JSON Schema meta-documents, not OpenAPI/Swagger specs.
+
+**Compile check technique:** Generated files are library-style (no `main`). Use `zig build-lib <file> -fno-emit-bin` — compiles as static lib, skips output emit, catches type/semantic errors. Does not require a `main` function.
+
+**CI integration note:** The existing `smoke-tests` job already exists in `.github/workflows/ci.yml` (lines 127–160) but only tests the petstore pair via `zig build run-generate`. The new script augments it — keep the petstore pair as a fast sanity check and add the PS script as a spec sweep step. `pwsh` is available on `ubuntu-latest` without extra setup.
+
+**Risk specs:**
+- `v3.0/ingram-micro.json` (755 KB) — may expose large-spec codegen edge cases
+- `v3.0/callback-example.json` — callbacks may not be fully supported
+- `v3.0/link-example.json` — link objects may produce incomplete output
+
+**Open question for Christian:** start with a denylist (skip known-broken, keep CI green) or allowlist (only known-passing, add others as fixed)? This is the primary governance question.
+
+**Proposal written:** `.squad/decisions/inbox/starkiller-smoke-test-plan.md`
+
+### Smoke Test Validation — Fenster's `test/smoke-tests.ps1` (2026-04-30)
+
+**Outcome: PASS** (script behavior). Generator gap surfaced on `openapi/v3.0/ingram-micro.json` is a separate triage item, not a script defect.
+
+**Static review against the approved plan — every requirement met:**
+- Repo root resolution: uses `$PSCommandPath` → `Split-Path -Parent` → `Resolve-Path "$ScriptDir/.."` and `Set-Location $RepoRoot`, so it runs correctly regardless of caller's CWD (CI uses `working-directory: test`).
+- Zig version check: `Find-Zig` resolves `Get-Command zig`, prints `zig version` before build; missing zig → red error + `exit 1`.
+- ReleaseFast build: default `-Optimize ReleaseFast`, invoked as `zig build -Doptimize=$Optimize`, build failure → `exit 1`.
+- Spec discovery: enumerates only `openapi/v2.0`, `v3.0`, `v3.1`, `v3.2`. `json-schema/` correctly excluded by not being in `$IncludedDirs`. YAML is filtered via lowercased extension check and counted into `$SkippedYaml` for the summary.
+- Sequential matrix: nested `foreach ($spec) { foreach ($mode) }`, indices `[idx/total]`, colored case labels.
+- Output dir: `$OutputDir = test/output`, wiped unless `-KeepOutput`, parent directories auto-created per (version, base, mode).
+- Compile check: `zig test <generated.zig>` — correct technique because generated files are library modules without `main()`. (Cleaner than `build-lib -fno-emit-bin`; `zig test` reports "All 0 tests passed" on success.)
+- Continue-all summary: per-case results stored in `$results`, summary prints Pass/Fail/Skip/Total + a failing-cases list grouped by phase (`generate`/`compile`).
+- Denylist: `Test-Denylisted` with `Spec` (path or `*`) × `Mode` (name or `*`) × `Reason`; intentionally empty with explanatory comment.
+- Non-zero exit: `exit 1` iff any non-denylisted case fails.
+
+**PowerShell parse check:** `[System.Management.Automation.Language.Parser]::ParseFile()` → no errors.
+
+**Focused run** (`-Filter "petstore" -Modes paths`, 9 cases): 9 PASS / 0 FAIL, exit 0.
+
+**Full sweep** (`pwsh test/smoke-tests.ps1`, 88 cases = 22 specs × 4 modes, ~5m14s on Windows + Zig 0.16.0):
+- 84 PASS / 4 FAIL / 0 SKIP, exit 1.
+- All 4 failures are `openapi/v3.0/ingram-micro.json` × {none,tags,paths,hybrid}, all in the `compile` phase.
+- Root cause is generator-side: emits multiple `pub const <SameName> = struct { ... }` declarations in the same Zig file (duplicate struct member name errors). Names like `QuoteDetailsRequestQuoteProductsRequestRetrieveQuoteProductsRequest` collide because the inline-schema name composer produces the same identifier from different schema sites. This is the exact "huge spec" risk I called out in the pre-plan inventory.
+- Same pattern across all four resource-wrapper modes → bug is in the unified model generator's name-uniquing, not the API/wrapper layer.
+
+**Governance call (open question for Lando + Christian):** the script is correct and the bug is real, so CI will go red on this PR. Three options: (a) Fenster fixes the duplicate-name path in `src/generators/unified/model_generator.zig` before merge; (b) populate `$Denylist` with the four ingram-micro entries, link a tracking issue, ship the script; (c) restrict full sweep to a curated allowlist for now. Recommendation: (b) — the smoke harness is valuable signal *now*, and the duplicate-name fix is its own focused PR.
+
+**CI integration (`.github/workflows/ci.yml`):**
+- Workflow file is `./smoke-tests.ps1` with `working-directory: test` and `shell: pwsh` → resolves to `test/smoke-tests.ps1` ✓.
+- `pwsh` is preinstalled on `ubuntu-latest` GitHub runners ✓.
+- Linux binary path: script uses `$IsWindows` to pick `openapi2zig` vs `openapi2zig.exe` ✓.
+- `actions/upload-artifact@v4` path `test/output/` matches `$OutputDir` ✓; `if: failure()` only — good, keeps green runs lean.
+- Job depends on `lint-and-format` and is gated on PR or `main`, alongside the existing `zig build run-generate` + `zig run generated/main.zig` petstore harness — that's the right layering: fast petstore sanity first, broad sweep second.
+- `.gitignore` correctly adds `test/output/`.
+- README "Smoke tests" section accurately describes the pwsh invocation and CI behavior.
+
+**No script defects found.** Validation artifacts (`test/output/`, `test/smoke-full.log`) cleaned up.
+
+### Smoke Test Final Gate — Post-Denylist (2026-04-30T16:31:22+02:00)
+
+**Outcome: PASS.** Final validation gate after Fenster added the `ingram-micro` denylist entry.
+
+**Denylist scoping check (static, `test/smoke-tests.ps1` lines 67–84):**
+- Single entry: `Spec="openapi/v3.0/ingram-micro.json"` (literal, slash-normalized) × `Mode="*"` × clear reason.
+- `Test-Denylisted` requires both `specMatch` AND `modeMatch`; literal spec string only matches that exact relpath, so other v3.0 specs are unaffected. `Mode="*"` correctly fans out across `none|tags|paths|hybrid`.
+- Reason string includes "(all wrapper modes)" — explicit and audit-friendly.
+- Comment block above the entry explains the generator gap and merge gate intent.
+
+**Focused runs (Windows + Zig 0.16.0, ReleaseFast):**
+- `pwsh -NoProfile -File test/smoke-tests.ps1 -Filter "v3.0/ingram-micro.json"` → 0 pass / 0 fail / 4 skip, **exit 0**. All four modes correctly skipped with denylist reason.
+- `pwsh -NoProfile -File test/smoke-tests.ps1 -Filter "v3.0/petstore.json" -Modes paths` → 1 pass / 0 fail / 0 skip, **exit 0**. Denylist does not bleed into unrelated specs.
+
+**Docs/CI alignment:**
+- `.github/workflows/ci.yml` smoke-tests job (lines 127–172) unchanged and still correct: invokes `./smoke-tests.ps1` from `test/`, uploads `test/output/` on failure only.
+- `README.md` (lines 177–194) already documents the denylist mechanism: "Honors a temporary denylist for known-unsupported spec/mode combinations so the PR gate can stay green while generator gaps are tracked explicitly." No doc drift.
+- `.gitignore` still covers `test/output/`.
+
+**No script defects, no doc drift, no CI drift.** Validation artifacts cleaned up.
+
+**Follow-up (separate work, not blocking this gate):** the duplicate `pub const` emission in `src/generators/unified/model_generator.zig` for `openapi/v3.0/ingram-micro.json` remains a real generator bug. Recommend a tracking issue so the denylist entry has a clear retire-when condition; until then the entry self-documents the gap.
+
+### YAML smoke coverage review (2026-05-01T11:50:14.189+02:00)
+
+**Smoke script scope:** `test/smoke-tests.ps1` now discovers both JSON and YAML specs and writes outputs as `<basename>__<format>__<mode>.zig`, which is required because 15 fixture basenames exist in both JSON and YAML form across `openapi/v2.0`, `openapi/v3.0`, and `openapi/v3.1`.
+
+**Validation results:** Focused YAML generation/compile passed for `openapi/v2.0/petstore.yaml` and `openapi/v3.0/petstore.yaml`, but the broader petstore-family smoke sweep still failed on `openapi/v2.0/petstore-expanded.yaml` and `openapi/v3.0/petstore-expanded.yaml` with `error.ParseFailure` during generation. YAML smoke coverage is therefore not ready to call green yet.
+
+**Harness caveat:** `generated/main.zig` still acts as a compile/init smoke harness more than a deterministic runtime proof. In local validation it printed `Generated models build and run !!` and initialized the YAML clients, but the live Swagger v2 call returned `error.ResponseError` and the program returned early without surfacing a non-zero failure, so broad smoke script results are the stronger acceptance signal for this feature.
+
+**Required completeness note:** `generated/compile_generated.zig` and `generated/main.zig` now import `generated_v2_yaml.zig`, `generated_v3_yaml.zig`, and `generated_v31_yaml.zig`, so those generated fixtures must be committed or produced before `zig build test` on a clean checkout.
+
+**Explicit risk checks from Lando's guidance:** JSON/YAML sibling collision protection is present in `test/smoke-tests.ps1` via `<basename>__<format>__<mode>.zig`, so sibling fixtures like `petstore.json` / `petstore.yaml` no longer overwrite each other. Generated harness aliases are also distinct (`v2`, `v2_yaml`, `v3`, `v3_yaml`, `v31`, `v31_yaml`, `v32`), so there is no alias shadowing in `generated/compile_generated.zig` or `generated/main.zig`.
+
+**YAML-only root coverage:** Smoke discovery does not require a JSON twin; it includes any `.json`, `.yaml`, or `.yml` under the allowed version roots. Confirmed with `openapi/v3.0/bot.paths.yaml`, which is discovered as a single YAML case and currently reports `SKIP` only because it is explicitly denylisted for a known YAML normalization `ParseFailure`, not because discovery dropped it.
+
+*To be updated as the team works.*