fix(spire): add missing trailing newline to values.yaml - #332
Merged
Conversation
yamllint's new-line-at-end-of-file rule fails on this file. ct lint only runs against charts a PR touches, so it stayed hidden until #331 modified the spire chart, and it will fail every future spire PR until fixed. Pre-existing, not introduced by #331: git show confirms the file already ended without a newline before that change.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
One byte.
charts/spire/values.yamlhas no trailing newline, so yamllint'snew-line-at-end-of-filerule fails:Pre-existing, not introduced by #331.
git show HEAD~1:charts/spire/values.yaml | tail -c 1returnst, so the file already ended without a newline.ct lintonly lints charts a PR touches, which is why it stayed invisible until #331 was the first PR in a while to modify this chart.Worth fixing rather than ignoring: it fails the lint job on every future spire chart PR, which trains people to merge past a red check. #331 itself merged with this failing, and the release published fine (spire-0.3.6, spectre-0.3.8 are both out), but that is not a habit worth keeping.
No chart version bump: this changes no rendered output.