ci: publish to npm before tagging + bump action runtimes to v5#13
Merged
Conversation
Reorder publish-npm so the npm publish runs before the git tag, branch push, GitHub release and PR. If the publish fails, none of those are created, so nothing ever points at a version that is not on npm. The 'current' (publish without bumping) path keeps its existing guard. Bump actions/checkout and actions/setup-node to v5 to clear the Node 20 runtime deprecation warning.
setup-node@v5 probes yarn for caching before Corepack is enabled, which fails on the global yarn 1 vs packageManager yarn 4 mismatch. Yarn's own global cache covers caching.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Two hardening changes to the release pipeline.
npm-first release order
publish-npmpushed the release branch, tag and PR before publishing to npm (the release PR body even warned it was only "safe to merge once the npm publish succeeded"). Now the build + publish runs first, and the tag, branch push, GitHub release and PR only run if it succeeds. Thecurrent(publish without bumping) path keeps its existing guard.Node 24 runtimes
Bump
actions/checkoutandactions/setup-nodeto v5 to clear the "Node.js 20 is deprecated" runtime warning.