Conversation
00200200
force-pushed
the
codex/clap-bash-hyphen-completion
branch
from
September 27, 2026 18:15
4bd42c8 to
2846166
Compare
Member
|
Our LLM policy specifically says that anything touching completion shell scripts cannot be AI generated. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR try to solve?
Closes #6386. For a binary named
my-app, the Bash generator normalized the root function name tomy__appbut also converted the hyphen in the root command path into a__subcmd__separator. As a result, the command-state strings could not match the generated nested-subcommand handlers, so completion stopped after entering the command. Normalize the root path consistently with the function name.Notes to reviewers
The existing
custom_bin_nameBash snapshot covers a hyphenated binary and nested subcommands; the other affected Bash snapshots now assert the corrected handler names.Validation:
cargo test -p clap_complete --test testsuite(77 passed);cargo fmt --check.LLM involvement: AI-assisted implementation and tests; the regression is covered by the generated-script snapshots.