Repository navigation
fix: include removed blocks in parsed output - #293
Open
RaphaelFakhri wants to merge 1 commit into
Open
RaphaelFakhri wants to merge 1 commit into
RaphaelFakhri wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Terraform 1.7 added the
removedblock. tfparse skips it: the block is missing from the parsed output, and the converter logsunknown block type type=removed. Policies can't see which resources a configuration removes from state, or whetherlifecycle { destroy = false }is set.This change adds
removedto the block types the converter emits, next tomoved. The block appears under theremovedkey.fromis a reference marker, andlifecycleis a nested object:Testing
test_removed_blockswith fixturetests/terraform/removed. It fails onmainwithKeyError: 'removed'and passes with this change.black --checkandflake8are clean.Closes #234