Conversation
pederbe
marked this pull request as ready for review
September 12, 2026 07:51
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The load balancer example uses
try_from_iter, which does not show how to attach backend extensions. Construct the static backends explicitly, attach typed names, and retrieve those names when logging the selected upstream. Initialize discovery before selection and retain the existing background TCP health checks.The example includes a deterministic test covering metadata through initialization, selection, and health filtering. It passes when run explicitly with
cargo test -p pingora-proxy --example load_balancer --features openssl.Closes #545.