TCOMMS: Please no on when off - #12773
Open
Drulikar wants to merge 4 commits into
Open
Conversation
cmss13-ci
Bot
added
Fix
cmss13-ci
Bot
added
size/S
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
About the pull request
This PR corrects an issue where tcomms were calling
tcomms_startup()with the assumption they should always beonwhen spawned, and nuke only checks theonvalue so leaving a tower alone was allowing the nuke to be decrypted with a tower effectively ignored.I also cleaned up some messages of "\The [src.name]" and removed a usage of
toggle_statewithout a user (that could potentially prevent a power change from turning it off)Explain why it's good for the game
Was intended for all towers to be needed for nuke even if you leave the second tower alone.
Testing Photographs and Procedure
Screenshots & Videos
When testing in USS runtime I had change the results for the is_ground_z define, and set the area to allow special structures (be sure to spawn the towers before the nuke)
Also testing on a normal ground map.
Changelog
🆑 Drathek
fix: Static tcomms no longer are "on" when initialized (namely for the purpose of nuke decryption checks)
/:cl: