fix: resolve startup toast version detection for local and cached installs#3317
Open
idoall wants to merge 1 commit intocode-yeongyu:devfrom
Open
fix: resolve startup toast version detection for local and cached installs#3317idoall wants to merge 1 commit intocode-yeongyu:devfrom
idoall wants to merge 1 commit intocode-yeongyu:devfrom
Conversation
Contributor
|
All contributors have signed the CLA. Thank you! ✅ |
Author
|
I have read the CLA Document and I hereby sign the CLA |
2dfb4e3 to
da0a006
Compare
There was a problem hiding this comment.
No issues found across 5 files
Confidence score: 5/5
- Automated review surfaced no issues in the provided summaries.
- No files require special attention.
Auto-approved: The PR expands version detection to support versioned cache directories and project-root configs with robust error handling and tests, posing no regression risk.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Testing
Summary by cubic
Fixes startup toast version detection so the correct plugin version is shown for local installs, versioned caches, and user-config installs.
CACHE_DIRfor versioned cache dirs (e.g.,oh-my-openagent@latest) and readspackage.jsonfromnode_modulesor the package root.node_moduleswhen cache entries are missing.opencode.json/opencode.jsoncover.opencode/opencode.jsonto detect localfile://plugins.oh-my-opencodeandoh-my-openagentduring version resolution.Written for commit da0a006. Summary will update on new commits.