feat: custom commit message on submit#82
Open
0xhasann wants to merge 2 commits intocodecrafters-io:mainfrom
Open
feat: custom commit message on submit#820xhasann wants to merge 2 commits intocodecrafters-io:mainfrom
0xhasann wants to merge 2 commits intocodecrafters-io:mainfrom
Conversation
Author
|
There are some Sample commits made using -m/--message for custom commit message. |
|
This is great! Hopefully its merged soon. Otherwise, I'd have to get this as a local copy |
Author
|
Hey @andy1li, could you pls review this PR. |
…nd update usage instructions for clarity.
Member
|
Hey @0xhasann, thanks so much for putting together the PR! I’ve cleaned it up a bit (mainly because we need the "[skip ci]" for every commit msg) and added a usage example. Will merge it once my boss reviews it. @rohitpaulk Error messages: 
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds support for custom commit messages in codecrafters submit.
Users can now pass a message using -m / --message:
codecrafters submit -m "commit message"
This change is inspired by a user discussion: #41 (comment)
. I also encountered the same limitation while using the CLI.
Open to feedback and happy to make any changes if needed.