Skip to content

fix: use hvc1 codec tag for HEVC output on macOS #123

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
sjhddh wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix: use hvc1 codec tag for HEVC output on macOS #123

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 9 additions & 0 deletions src-tauri/src/core/ffmpeg.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -260,6 +260,15 @@ impl FFMPEG {
};
cmd_args.extend_from_slice(&["-c:v:0", output_codec.as_str()]);

// For HEVC codecs in MP4/MOV containers, use hvc1 tag for Apple compatibility.
// By default ffmpeg writes hev1, which macOS Finder/QuickLook/QuickTime don't recognize.
let needs_hvc1_tag = (output_codec.contains("265")
|| output_codec.contains("hevc"))
&& matches!(convert_to_extension, "mp4" | "mov");
if needs_hvc1_tag {
cmd_args.extend_from_slice(&["-tag:v:0", "hvc1"]);
}

// Quality
let compression_quality: String = {
let default_crf: u16 = 28;
Expand Down