Fix editor crash for widgets disabled in editor#2449
Merged
Conversation
Since packs are only loaded for editor-enabled widgets, the editor preview must not try to render widgets that are disabled in the editor. Otherwise their widget type is not registered and rendering fails, breaking the editor for entries using such a widget. Exclude editor-disabled widgets from the preview so they no longer run inside the editor, matching the intent of disabling them there. REDMINE-21330
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Since packs are only loaded for editor-enabled widgets, the editor preview must not try to render widgets that are disabled in the editor. Otherwise their widget type is not registered and rendering fails, breaking the editor for entries using such a widget.
Exclude editor-disabled widgets from the preview so they no longer run inside the editor, matching the intent of disabling them there.
REDMINE-21330