Skip to content

docs(deps): install missing dependency for ogImage rendering#263

Open
arashsheyda wants to merge 1 commit into
mainfrom
docs/ogImage
Open

docs(deps): install missing dependency for ogImage rendering#263
arashsheyda wants to merge 1 commit into
mainfrom
docs/ogImage

Conversation

@arashsheyda

Copy link
Copy Markdown
Collaborator

🔗 Linked issue

❓ Type of change

  • 📖 Documentation (updates to the documentation or readme)
  • 🐞 Bug fix (a non-breaking change that fixes an issue)
  • 👌 Enhancement (improving an existing functionality like performance)
  • ✨ New feature (a non-breaking change that adds functionality)
  • ⚠️ Breaking change (fix or feature that would cause existing functionality to change)

📚 Description

currently if you try to access the ogImage, it's not working (500) as it's broken. this PR adds the missing dep to fix it

📝 Checklist

  • I have linked an issue or discussion.
  • I have run pnpm verify and it passes.
  • I have updated the documentation accordingly.

@arashsheyda arashsheyda requested a review from farnabaz as a code owner July 2, 2026 15:45
@vercel

vercel Bot commented Jul 2, 2026

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
comark Error Error Jul 2, 2026 3:45pm
comark-json-render Error Error Jul 2, 2026 3:45pm
comark-nextjs Error Error Jul 2, 2026 3:45pm
comark-nuxt Error Error Jul 2, 2026 3:45pm
comark-svelte Error Error Jul 2, 2026 3:45pm
comark-sveltekit Error Error Jul 2, 2026 3:45pm
comark-twoslash Error Error Jul 2, 2026 3:45pm
comark-vue Error Error Jul 2, 2026 3:45pm

Comment thread docs/package.json
},
"devDependencies": {
"@nuxt/devtools-kit": "catalog:",
"@resvg/resvg-js": "catalog:",

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

according to the ogImage docs, this is needed for node env, for vercel edge time we need another dep https://nuxtseo.com/docs/og-image/renderers/satori#installation

are the docs running on edge?

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Docs are running on Vercel.
I wonder how we have it working now without this dependency?!

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

are you sure it's working? for me when I try to access the ogImage I see 500 errors: https://comark.dev/_og/s/o_dzoei9.png
Screenshot 2026-07-14 at 8 11 21 AM

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

😱 So based on Docs we need to add @resvg/resvg-wasm for Vercel, right?

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes (if we're running on vercel edge only tho) vercel node should be fine with @resvg/resvg-js

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants