fix(codeowners): correct webhooks owner handle and glob pattern - #508
Open
ketanyekale wants to merge 1 commit into
Open
fix(codeowners): correct webhooks owner handle and glob pattern#508ketanyekale wants to merge 1 commit into
ketanyekale wants to merge 1 commit into
Conversation
Two bugs on the webhooks rule: 1. @Siva is not the CometChat Siva. It resolves to 'Satish Gunnu', an account created in 2008 that is neither a cometchat org member nor a collaborator on this repo, so GitHub silently drops the rule and no review is ever requested for webhooks docs. Every other entry for the same person uses @siva-cometchat, who owns /rest-api/ and the API schema files and is a verified org member and repo collaborator. 2. CODEOWNERS uses gitignore-style patterns, where a backslash escapes the asterisk into a literal '*' character. 'webhooks\*.mdx' therefore matched only a file literally named 'webhooks*.mdx' and matched neither fundamentals/webhooks.mdx nor fundamentals/webhooks-overview.mdx. Unescaped, it matches both. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
|
Preview deployment for your docs. Learn more about Mintlify Previews.
💡 Tip: Enable Automations to automatically generate PRs for you. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The last rule in
CODEOWNERShas two independent bugs, and as written it assigns no reviewer at all:1.
@sivais not the CometChat Siva@sivaresolves to a real account — but not the right one:@siva@siva-cometchatcometchat/docscollaboratorEvery other entry for this person uses
@siva-cometchat, who already owns/rest-api/,/moderation/and the API schema JSON files. Because@sivahas no access to this repo, GitHub silently ignores the rule rather than erroring — so webhooks docs changes have never requested a review from anyone.2. The wildcard is escaped, so it matches nothing
CODEOWNERS uses gitignore-style patterns, where
\*escapes the asterisk into a literal*character.webhooks\*.mdxtherefore matches only a file literally namedwebhooks*.mdx, and matches neither of the files that exist:fundamentals/webhooks.mdxfundamentals/webhooks-overview.mdxUnescaped,
/fundamentals/webhooks*.mdxmatches both (verified against the actual filenames).Either bug alone would disable the rule; together they made it doubly inert. After this change, webhooks documentation changes will request review from
@siva-cometchat.Note
This PR deliberately does not touch line 9 (
- @jitvarpatil), which uses-instead of*as its pattern and so is a no-op as the intended repo-wide default owner. That is raised separately for a decision in #504.🤖 Generated with Claude Code