Repository navigation
Conversation
Allow users to select the existing pod or container port placement explicitly. Reject container publishing with --pod because Podman requires pod-level publishing, and document the supported standalone-container workflow. Closes: containers#225 Signed-off-by: Cristian Filipescu <filipescu.cristian@gmail.com>
Rust 1.99 warns when the color-eyre bail macro is used as a match expression, and CI promotes that warning to an error. Use statement-position invocations for all affected match arms. Signed-off-by: Cristian Filipescu <filipescu.cristian@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
compose --port-placement=pod|containerso the existing port placement choice can be made explicit without changing defaults.--pod --port-placement=containerwith an actionable error. Podman requires ports of containers in a pod to be published by the pod, so generating container-levelPublishPort=alongsidePod=would produce an unsupported configuration.podlet compose --port-placement=container, which generates separate container Quadlets with each service's ports preserved.Validation
cargo testcargo fmt --checkcargo clippyCloses #225