Repository navigation
Fix unit tests with urllib3 2.8 - #670
Open
ricardobranco777 wants to merge 1 commit into
Open
ricardobranco777 wants to merge 1 commit into
ricardobranco777 wants to merge 1 commit into
Conversation
urllib3 < 2.8 lowercased the whole host of the requested URL, so the percent-encoded unix socket path became %2frun%2fapi.sock, and the tests compared it against a lowercased expected URL. Since urllib3 2.8.0 (urllib3/urllib3#5095, commit 6284887a "Reject invalid URL hosts") percent-encoded octets in the host are normalized to uppercase (RFC 3986), so those comparisons fail. Lowercase the recorded request URL as well so the tests pass with both old and new urllib3. Signed-off-by: Ricardo Branco <rbranco@suse.de>
Contributor
Author
|
Verification run: https://openqa.opensuse.org/tests/6251415 |
Contributor
Author
|
Looks like #667 fixed it first. |
Member
|
@ricardobranco777 Thanks for the contribution! However, this is already fixed in #658. Could you please close this PR and review #658 instead? Thanks in advance! |
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
urllib3 < 2.8 lowercased the whole host of the requested URL, so the percent-encoded unix socket path became
%2frun%2fapi.sock, and the tests compared it against a lowercased expected URL.Since urllib3 2.8.0 (urllib3/urllib3#5095, commit 6284887a "Reject invalid URL hosts") percent-encoded octets in the host are normalized to uppercase (RFC 3986), so those comparisons fail.
Lowercase the recorded request URL as well so the tests pass with both old and new urllib3.
Otherwise tests fail in openQA like this:
https://openqa-assets.opensuse.org/tests/6251400/file/python_podman-unit.txt