Repository navigation
fix: handle string State payload in Container.status - #671
Open
reginaldalfret wants to merge 1 commit into
Open
reginaldalfret wants to merge 1 commit into
reginaldalfret wants to merge 1 commit into
Conversation
Containers returned by containers.list() contain a string State attribute rather than a dictionary. Support string State in Container.status property so it does not raise TypeError. Fixes containers#662 Signed-off-by: reginaldalfret <reginaldalfret@gmail.com>
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Containers returned by
containers.list()carry the list payload whereStateis represented as a string (such as"created"or"running") rather than an inspect dictionary. In that case, accessingContainer.statusraised aTypeErrorwhen indexing the string.This PR updates
Container.statusto handle both string and dict representations ofState, returning"unknown"if missing, and adds unit tests covering both inspect and list payloads.Fixes #662
Signed-off-by: reginaldalfret reginaldalfret@gmail.com