chore: integration test keys#495
Open
Maya Karabuła-Stysiak (mayakarabula) wants to merge 9 commits intomainfrom
Open
chore: integration test keys#495Maya Karabuła-Stysiak (mayakarabula) wants to merge 9 commits intomainfrom
Maya Karabuła-Stysiak (mayakarabula) wants to merge 9 commits intomainfrom
Conversation
Maya Karabuła-Stysiak (mayakarabula)
requested a review
from a team
as a code owner
| import { ApiKey, Environment } from 'contentful-management' | ||
| import { CreateApiKeyProps, Space } from 'contentful-management/types' | ||
|
|
||
| export const INTEGRATION_TEST_KEY = '5HAbGYZ6iZWiDXGxMtvsrW' |
There was a problem hiding this comment.
Can we name them something along the line of "access key id"?
| try { | ||
| cdaTokenWithOnlyMasterAccess = await testSpace.getApiKey(INTEGRATION_TEST_KEY_MASTER) | ||
| } catch (e) { | ||
| cdaTokenWithOnlyMasterAccess = await createCdaToken(testSpace, ['master']) |
There was a problem hiding this comment.
In what case would we end up in the catch clause?
Contributor
Author
There was a problem hiding this comment.
if the key is not found, for example, if it was removed
Member
|
Love it - thank you! 🎉 |
Member
|
Maya Karabuła-Stysiak (@mayakarabula) Should we merge it? :) |
Maya Karabuła-Stysiak (mayakarabula)
requested a review
from a team
as a code owner
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
integration test take a lot of time because we are generating new keys every time, we can just add and remove environments from one predefined key