fix: HEALTHCHECK detection respects dockerfile_target_build in multi-stage Dockerfiles#9477
Open
jeongkichang wants to merge 2 commits intocoollabsio:nextfrom
Open
Conversation
…stage Dockerfiles When using multi-stage Dockerfiles with dockerfile_target_build, parseHealthcheckFromDockerfile now only searches for HEALTHCHECK within the target stage instead of the entire Dockerfile text. Also adds HEALTHCHECK NONE handling per Docker specification. Fixes coollabsio#9475
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
When using multi-stage Dockerfiles with
dockerfile_target_build,parseHealthcheckFromDockerfilesearched the entire Dockerfile text for "HEALTHCHECK" regardless of target stage. This caused incorrect healthcheck configuration from other stages to be applied.extractTargetStageLines()toApplication.phpthat parsesFROM ... AS <stage>boundaries and returns only lines within the target stagedockerfile_target_buildis not set, falls back to original behavior (all lines)HEALTHCHECK NONEhandling — returns early without applying any healthcheck configIssues
Category
Preview
N/A — backend logic change, no UI changes.
AI Assistance
If AI was used:
Testing
Tested scenarios:
apiwith HEALTHCHECK → detected correctlyworkerwithout HEALTHCHECK → not detected (fixed behavior)HEALTHCHECK NONEin target stage → treated as explicit disableContributor Agreement
Important