Repository navigation
Conversation
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info
📜 Recent review details
📝 Walkthrough
Merge Risk: ⚪ Minimal · up to
|
| Check name | Status | Explanation | Resolution |
|---|---|---|---|
| Title check |  |
The title clearly describes the KubeVirt NoCloud change and uses the required subsystem prefix, imperative mood, and length. It fails the lowercase-after-colon requirement because it uses "Support". | Change the title to "kubevirt: support default route destinations in NoCloud config". |
-
Check name Status Explanation Description check The description directly explains the parsing failure, the shared helper, the IPv4 and IPv6 behavior, and the added tests and fixtures. Docstring Coverage Docstring coverage is 87.50% which is sufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff. Analyzed 8 functions across 2 files. (1 skipped: 1 u… Linked Issues check Check skipped because no linked issues were found for this pull request. Out of Scope Changes check Check skipped because no linked issues were found for this pull request. Commit Message Convention The PR contains one non-merge commit. Its subject is kubevirt: Support \\default\route destinations in NoCloud config, which uses a valid subsystem prefix, an imperative description, no trailing p…Release Notes The PR changes user-visible KubeVirt NoCloud networking behavior, and it updates docs/release-notes.md. The new Upcoming Afterburn 5.12.0 minor-change entry states: “KubeVirt: Supportdefaultrout…
- Fix all pre-merge checks with AI
✨ Finishing Touches
-
🧪 Generate unit tests (beta)
-
- Create a new PR
-
- Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts
Comment @coderabbitai help to get the list of available commands.
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
Binary size report (
|
| Size | |
|---|---|
Base (main) |
4.7MiB |
| PR (#1310) | 4.7MiB |
| Delta | +512B (0.01%) |
Ar-maan05
force-pushed
the
kubevirt-nocloud-route-to-default
branch
from
October 13, 2026 18:02
e149e46 to
b3c48e0
Compare
cloud-init and Netplan accept `default` as a route destination, and
Netplan recommends `routes: [{to: default, via: ...}]` over the
deprecated `gateway4` and `gateway6` keys. The NoCloud parser passed
the v2 `to` and v1 `destination` fields straight to
`IpNetwork::from_str()`, so such a config failed with "invalid address:
default" and the whole network configuration was rejected, leaving the
instance without any network kargs.
Map `default` to `0.0.0.0/0` or `::/0` depending on the address family
of the gateway, the same way cloud-init normalizes it.
Signed-off-by: Armaan Sandhu <armaan.sandhu0504@gmail.com>
Ar-maan05
force-pushed
the
kubevirt-nocloud-route-to-default
branch
from
October 14, 2026 15:18
b3c48e0 to
f6d106d
Compare
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
cloud-init and Netplan accept
defaultas a route destination, and Netplan recommendsroutes: [{to: default, via: ...}]over the deprecatedgateway4/gateway6keys. The KubeVirt NoCloud parser passed the v2toand v1destinationfields directly toIpNetwork::from_str(), so user-suppliednetworkDatalike this:made
networks()andrd_network_kargs()fail withinvalid address: default, rejecting the whole network configuration rather than just the route.This adds a small
parse_route_destination()helper used by both the v1 and v2 paths, which mapsdefaultto0.0.0.0/0or::/0based on the address family of the gateway. That matches cloud-init's own normalization in_normalize_net_keys()(cloudinit/net/network_state.py).New v1 and v2 fixtures cover both address families; both tests fail on
mainand pass with this change, and both fixtures passmake validate-fixturesagainst the upstream cloud-init schemas.