Skip to content

chore(vpat): polish vpat with exec summary and margins#7889

Open
y-lakhdar wants to merge 2 commits into
mainfrom
KIT-5848
Open

chore(vpat): polish vpat with exec summary and margins#7889
y-lakhdar wants to merge 2 commits into
mainfrom
KIT-5848

Conversation

@y-lakhdar

Copy link
Copy Markdown
Contributor

add margins and 2 new sections
image

Copilot AI review requested due to automatic review settings June 26, 2026 15:33
@changeset-bot

changeset-bot Bot commented Jun 26, 2026

Copy link
Copy Markdown

⚠️ No Changeset found

Latest commit: e3ae2f7

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@svcsnykcoveo

svcsnykcoveo commented Jun 26, 2026

Copy link
Copy Markdown

Snyk checks have passed. No issues have been found so far.

Status Scan Engine Critical High Medium Low Total (0)
Open Source Security 0 0 0 0 0 issues
Licenses 0 0 0 0 0 issues
Code Security 0 0 0 0 0 issues

💻 Catch issues earlier using the plugins for VS Code, JetBrains IDEs, Visual Studio, and Eclipse.

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR polishes the Atomic accessibility VPAT output by adding an Executive Summary and Testing Methodology section, improving PDF pagination/margins, and updating the wording used in conformance remarks to clarify that counts are “applicable components”.

Changes:

  • Added a conformanceSummary Handlebars helper and new “Executive Summary” + “Testing Methodology” sections in the VPAT markdown template.
  • Updated the generated PDF layout by moving margins into Playwright PDF settings.
  • Tweaked conformance remark phrasing and aligned the checked-in openacr.yaml report text accordingly.

Reviewed changes

Copilot reviewed 5 out of 5 changed files in this pull request and generated 1 comment.

Show a summary per file
File Description
packages/atomic-a11y/src/openacr/vpat-renderer.ts Adds a Handlebars helper to compute executive summary counts from the report chapters.
packages/atomic-a11y/src/openacr/conformance.ts Adjusts the “no violations” evidence string to clarify “applicable component(s)”.
packages/atomic-a11y/scripts/vpat-from-openacr.handlebars Adds VPAT Executive Summary + Testing Methodology sections and renders conformance counts.
packages/atomic-a11y/scripts/build-vpat-pdf.mjs Updates PDF generation to use explicit margins (instead of CSS padding).
packages/atomic-a11y/reports/openacr.yaml Updates report text to match the new conformance remark phrasing.

Comment on lines +59 to +61
// Counts every Level A/AA criterion by its resolved conformance, for the
// Executive Summary. Computed from the rendered rows so it can never drift
// from the tables below.
@pkg-pr-new

pkg-pr-new Bot commented Jun 26, 2026

Copy link
Copy Markdown
@coveo/atomic

npm i https://pkg.pr.new/@coveo/atomic@7889

@coveo/atomic-hosted-page

npm i https://pkg.pr.new/@coveo/atomic-hosted-page@7889

@coveo/atomic-legacy

npm i https://pkg.pr.new/@coveo/atomic-legacy@7889

@coveo/atomic-react

npm i https://pkg.pr.new/@coveo/atomic-react@7889

@coveo/auth

npm i https://pkg.pr.new/@coveo/auth@7889

@coveo/bueno

npm i https://pkg.pr.new/@coveo/bueno@7889

@coveo/create-atomic

npm i https://pkg.pr.new/@coveo/create-atomic@7889

@coveo/create-atomic-component

npm i https://pkg.pr.new/@coveo/create-atomic-component@7889

@coveo/create-atomic-component-project

npm i https://pkg.pr.new/@coveo/create-atomic-component-project@7889

@coveo/create-atomic-result-component

npm i https://pkg.pr.new/@coveo/create-atomic-result-component@7889

@coveo/create-atomic-rollup-plugin

npm i https://pkg.pr.new/@coveo/create-atomic-rollup-plugin@7889

@coveo/headless

npm i https://pkg.pr.new/@coveo/headless@7889

@coveo/headless-react

npm i https://pkg.pr.new/@coveo/headless-react@7889

@coveo/shopify

npm i https://pkg.pr.new/@coveo/shopify@7889

commit: e3ae2f7

@chromatic-com

chromatic-com Bot commented Jun 26, 2026

Copy link
Copy Markdown

Tip

All tests passed and all changes approved!

🟢 UI Tests: 457 tests unchanged
🟢 UI Review: 457 stories published -- no changes
Storybook icon Storybook Publish: 457 stories published

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants