Conversation
|
✅ Snyk checks have passed. No issues have been found so far.
💻 Catch issues earlier using the plugins for VS Code, JetBrains IDEs, Visual Studio, and Eclipse. |
There was a problem hiding this comment.
Pull request overview
This PR polishes the Atomic accessibility VPAT output by adding an Executive Summary and Testing Methodology section, improving PDF pagination/margins, and updating the wording used in conformance remarks to clarify that counts are “applicable components”.
Changes:
- Added a
conformanceSummaryHandlebars helper and new “Executive Summary” + “Testing Methodology” sections in the VPAT markdown template. - Updated the generated PDF layout by moving margins into Playwright PDF settings.
- Tweaked conformance remark phrasing and aligned the checked-in
openacr.yamlreport text accordingly.
Reviewed changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| packages/atomic-a11y/src/openacr/vpat-renderer.ts | Adds a Handlebars helper to compute executive summary counts from the report chapters. |
| packages/atomic-a11y/src/openacr/conformance.ts | Adjusts the “no violations” evidence string to clarify “applicable component(s)”. |
| packages/atomic-a11y/scripts/vpat-from-openacr.handlebars | Adds VPAT Executive Summary + Testing Methodology sections and renders conformance counts. |
| packages/atomic-a11y/scripts/build-vpat-pdf.mjs | Updates PDF generation to use explicit margins (instead of CSS padding). |
| packages/atomic-a11y/reports/openacr.yaml | Updates report text to match the new conformance remark phrasing. |
| // Counts every Level A/AA criterion by its resolved conformance, for the | ||
| // Executive Summary. Computed from the rendered rows so it can never drift | ||
| // from the tables below. |
@coveo/atomic
@coveo/atomic-hosted-page
@coveo/atomic-legacy
@coveo/atomic-react
@coveo/auth
@coveo/bueno
@coveo/create-atomic
@coveo/create-atomic-component
@coveo/create-atomic-component-project
@coveo/create-atomic-result-component
@coveo/create-atomic-rollup-plugin
@coveo/headless
@coveo/headless-react
@coveo/shopify
commit: |
|
Tip All tests passed and all changes approved!🟢 UI Tests: 457 tests unchanged |
add margins and 2 new sections
