Skip to content

feat(atomic): Add E2E coverage for agent follow-up error handling#7909

Merged
SimonMilord merged 62 commits into
mainfrom
SFINT-6775
Jul 8, 2026
Merged

feat(atomic): Add E2E coverage for agent follow-up error handling#7909
SimonMilord merged 62 commits into
mainfrom
SFINT-6775

Conversation

@SimonMilord

@SimonMilord SimonMilord commented Jun 30, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor

SFINT-6775

Adds comprehensive E2E test coverage for follow-up answer analytics and error handling in the atomic-generated-answer component.

Tested analytics on the following:

- like/dislike
- copy-to-clipboard
- hover citation (generatedAnswerSourceHover)
- click citation (generatedAnswerFollowupOpenSource)
- follow-up request body
  • Added a step verifying that interacting with the 2nd answer (after generating a 3rd and expanding via "show previous") sends analytics with the correct answer-scoped IDs

New tests for:
- Network failure → displays generic error message
- SSE turn-limit error (KNOWLEDGE:SSE_TURN_LIMIT_REACHED) → displays distinct turn-limit message
- SSE internal error (KNOWLEDGE:SSE_INTERNAL_ERROR) → displays generic error message

Storybook stories

  • FollowUpNetworkError, FollowUpTurnLimitError, FollowUpGenericError dedicated stories that mock the follow-up endpoint to return each error type

SimonMilord and others added 30 commits June 23, 2026 12:40
@SimonMilord
first draft e2e
934edda
@SimonMilord
improved tests
c8dc281
@SimonMilord
removed the extra story
64064f4
@SimonMilord
moved selectors to page-object
8517c8c
@SimonMilord
simplified test
506d6da
@SimonMilord
re-added test for button disabled
7c7e637
@SimonMilord
updated tests
40e7d5c
@SimonMilord
try to fix ci test
e1e4967
@SimonMilord
try to fix failing CI tests due to ensures MSW is ready for all subse…
48aac7d 
…quent test navigations in the describe block
@SimonMilord
try a fix
e825015
@SimonMilord
try another fix
d7d1ff2
@SimonMilord
updated ag ui client to 0.0.57
3c1f989
@SimonMilord
removed ag ui from the minimumReleaseAgeExclude
267851e
@SimonMilord
refactored the tests to be serial
b6ad896
@SimonMilord
added dependency for ag ui in catalog
758eba1
@SimonMilord
update lock file
30bf593
@SimonMilord
added more interactions tests analytics to come later
b6747e8
@SimonMilord
fixed CI
8c6290e
@SimonMilord
fixed CI
1b58f6e
@SimonMilord
Merge branch 'SFINT-6774' of https://github.com/coveo/ui-kit into SFI…
d17e397 
…NT-6774
@SimonMilord
applied feedback from etienne
907cff2
@SimonMilord
chore: merge main into SFINT-6774
711c089 
Co-authored-by: SimonMilord <73316533+SimonMilord@users.noreply.github.com>
@SimonMilord
feedback
6db0d7f
@SimonMilord
Merge branch 'SFINT-6774' of https://github.com/coveo/ui-kit into SFI…
8900856 
…NT-6774
@SimonMilord
added mehdi feedback
c582893
@SimonMilord
Merge branch 'main' into SFINT-6774
0992ad8
@SimonMilord
fix unused dep
53f7ca7
@SimonMilord
increased timeout
87a7d89
@SimonMilord
Merge branch 'main' into SFINT-6774
aded238
@SimonMilord
made everything 1 test
37d0027
erocheleau
erocheleau approved these changes Jul 7, 2026
View reviewed changes

@erocheleau erocheleau left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@mmitiche

mmitiche commented Jul 7, 2026

Copy link
Copy Markdown
Contributor

what's the goal of this PR? adding E2E or adding storybook stories?

@SimonMilord

SimonMilord commented Jul 7, 2026

Copy link
Copy Markdown
Contributor Author

what's the goal of this PR? adding E2E or adding storybook stories?

tests were removed in a merge for some reason, I re-added them

mmitiche
mmitiche reviewed Jul 7, 2026
View reviewed changes
Comment thread packages/platform-mock-api/src/agent/generate-response.ts Outdated
mmitiche
mmitiche approved these changes Jul 7, 2026
View reviewed changes

@mmitiche mmitiche left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, just a portion that can be refactored to avoid duplicating logic.

@SimonMilord SimonMilord enabled auto-merge July 8, 2026 13:59
@SimonMilord SimonMilord added this pull request to the merge queue Jul 8, 2026
Merged via the queue into main with commit a37dca8 Jul 8, 2026
69 checks passed
@SimonMilord SimonMilord deleted the SFINT-6775 branch July 8, 2026 14:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

Copilot code review Copilot Copilot left review comments
@erocheleau erocheleau erocheleau approved these changes
@mmitiche mmitiche mmitiche approved these changes
@mikegron mikegron Awaiting requested review from mikegron
@y-lakhdar y-lakhdar Awaiting requested review from y-lakhdar y-lakhdar was automatically assigned from coveo/dxui
@louis-bompart louis-bompart Awaiting requested review from louis-bompart louis-bompart was automatically assigned from coveo/dxui
@fbeaudoincoveo fbeaudoincoveo Awaiting requested review from fbeaudoincoveo fbeaudoincoveo was automatically assigned from coveo/dxui
@jpmarceau jpmarceau Awaiting requested review from jpmarceau jpmarceau was automatically assigned from coveo/dev-writers
@jsmith2-coveo jsmith2-coveo Awaiting requested review from jsmith2-coveo jsmith2-coveo was automatically assigned from coveo/dev-writers
@tbaxter-coveo tbaxter-coveo Awaiting requested review from tbaxter-coveo tbaxter-coveo was automatically assigned from coveo/dev-writers

Assignees

No one assigned

Labels

area:atomic area:documentation area:generated-answer team:dev-writers team:dxui team:knowledge-ui-kit-reviewers

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@SimonMilord @svcsnykcoveo @mmitiche @erocheleau