Skip to content

Add initial implementation - #1

Merged
marcospassos merged 11 commits into
masterfrom
initial-implementation
Jun 17, 2026
Merged

marcospassos merged 11 commits into
masterfrom
initial-implementation

Conversation

@marcospassos

Copy link
Copy Markdown
Member

Summary

Add initial implementation.

Checklist

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules
  • I have checked my code and corrected any misspellings

@marcospassos marcospassos added the feature New feature label Jun 4, 2026
@marcospassos
marcospassos force-pushed the initial-implementation branch from 983349b to eeb0bf1 Compare June 4, 2026 18:48
Comment thread src/ContentResolver.php
Comment thread src/ContentResolver.php
Comment thread src/ContentResolver.php
Comment thread src/ContentResolver.php
@marcospassos

Copy link
Copy Markdown
Member Author

@renan628, regarding your comment: the expected behavior is to return null whenever something does not match, so the original content is used instead. These are treated as unexpected cases that should never happen. This is basically a port of JS code.

Comment thread src/CroctStoriesApi.php Outdated
Comment thread src/ContentResolver.php Outdated
@denis-rossati

Copy link
Copy Markdown
Member

Appart from the existing comments, lgtm

@marcospassos
marcospassos merged commit 45ff301 into master Jun 17, 2026
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

feature New feature

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants