Add ability to save and switch named sets of parallel modules.#1348
Open
LAfricain wants to merge 3 commits into
Open
Add ability to save and switch named sets of parallel modules.#1348LAfricain wants to merge 3 commits into
LAfricain wants to merge 3 commits into
Conversation
Replace the vendored win32/include/X11/keysymdef.h with a find_path() call that locates the header from the host system's X11 installation. This avoids maintaining a stale copy in the repository and makes the missing-dependency case fail early with a clear CMake error rather than a cryptic compile error. Note: libx11-dev (or equivalent) must be installed on the build host, including on Wayland-only systems where it may not be present by default. Closes crosswire#1024
Contributor
Author
|
I just fixed the problem for Windows, but in doing so, I discovered another one: a new set isn't saved—once Xiphos is closed, it disappears. And there's no option to delete sets. I'll take care of that as soon as possible. |
Add ability to save and switch named sets of parallel modules. UI: - 'Sets' menu button in the parallel view toolbar; clicking it shows a popup menu of saved sets plus 'Manage...' which opens Preferences directly on the Modules > Parallel page - GtkComboBoxText in Preferences > Modules > Parallel to select which set is being edited; 'New set...' creates a new set from the current parallel module list Storage (settings.xml, [modules] section): parallel_set_names=NT,AT parallel_set_current=NT parallel_set_NT=BSB,FreCrampon,FreINT parallel_set_AT=BSB,FreCrampon,WLC Fully backward-compatible: falls back to existing parallel_list if no sets are defined. New helpers in settings.c: get_parallel_set(name) - returns module list for a named set save_parallel_set(name) - saves module list for a named set
Add ability to save and switch named sets of parallel modules. UI: - 'Sets' menu button in the parallel view toolbar; clicking it shows a popup menu of saved sets plus 'Manage...' which opens Preferences directly on the Modules > Parallel page - GtkComboBoxText in Preferences > Modules > Parallel to select which set is being edited; 'New set...' creates a new set from the current parallel module list Storage (settings.xml, [modules] section): parallel_set_names=NT,AT parallel_set_current=NT parallel_set_NT=BSB,FreCrampon,FreINT parallel_set_AT=BSB,FreCrampon,WLC Fully backward-compatible: falls back to existing parallel_list if no sets are defined. New helpers in settings.c: get_parallel_set(name) - returns module list for a named set save_parallel_set(name) - saves module list for a named set
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Solves #639
UI:
a popup menu of saved sets plus 'Manage...' which opens Preferences
directly on the Modules > Parallel page
set is being edited; 'New set...' creates a new set from the current
parallel module list
Storage (settings.xml, [modules] section):
parallel_set_names=NT,AT
parallel_set_current=NT
parallel_set_NT=BSB,FreCrampon,FreINT
parallel_set_AT=BSB,FreCrampon,WLC
Fully backward-compatible: falls back to existing parallel_list if no
sets are defined.
New helpers in settings.c:
get_parallel_set(name) - returns module list for a named set
save_parallel_set(name) - saves module list for a named set"