Repository navigation
Conversation
…moved `shards lock` returned early when the resolver produced no packages, so a stale `shard.lock` kept listing dependencies that had been removed from `shard.yml`, and no lockfile was written for projects without dependencies. `shards install` and `shards update` already write an empty lockfile in this case since crystal-lang#453. Assisted-by: Gemini <gemini@google.com> Signed-off-by: Rénich Bon Ćirić <renich@woralelandia.com>
straight-shoota
approved these changes
Nov 6, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #743
shards lockreturned early when the resolver produced no packages. A staleshard.lockkept listing dependencies already removed fromshard.yml, and no lockfile was written for projects without dependencies. Dropping the early return matches whatshards installandshards updatehave done since #453: they writeshards: {}.The new
updates lockfile on completely removed dependenciesspec fails onmasterand passes with this change. I replaced the existingdoesn't generate lockfile when project has no dependenciesexample because it pinned the old behavior. The full integration suite passes locally (217 examples, 0 failures).