Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion slither/detectors/attributes/const_functions_asm.py
Original file line number Diff line number Diff line change
Expand Up @@ -45,7 +45,7 @@ class ConstantFunctionsAsm(AbstractDetector):
uint counter;
function get() public view returns(uint){
counter = counter +1;
return counter
return counter;
}
}
```
Expand Down
2 changes: 1 addition & 1 deletion slither/detectors/attributes/const_functions_state.py
Original file line number Diff line number Diff line change
Expand Up @@ -45,7 +45,7 @@ class ConstantFunctionsState(AbstractDetector):
uint counter;
function get() public view returns(uint){
counter = counter +1;
return counter
return counter;
}
}
```
Expand Down
2 changes: 1 addition & 1 deletion slither/detectors/functions/dead_code.py
Original file line number Diff line number Diff line change
Expand Up @@ -30,7 +30,7 @@ class DeadCode(AbstractDetector):
WIKI_EXPLOIT_SCENARIO = """
```solidity
contract Contract{
function dead_code() internal() {}
function dead_code() internal {}
}
```
`dead_code` is not used in the contract, and make the code's review more difficult."""
Expand Down
2 changes: 1 addition & 1 deletion slither/detectors/reentrancy/reentrancy_benign.py
Original file line number Diff line number Diff line change
Expand Up @@ -40,7 +40,7 @@ class ReentrancyBenign(Reentrancy):
if( ! (msg.sender.call()() ) ){
throw;
}
counter += 1
counter += 1;
}
```

Expand Down
2 changes: 1 addition & 1 deletion slither/detectors/reentrancy/reentrancy_no_gas.py
Original file line number Diff line number Diff line change
Expand Up @@ -44,7 +44,7 @@ class ReentrancyNoGas(Reentrancy):
WIKI_EXPLOIT_SCENARIO = """
```solidity
function callme(){
msg.sender.transfer(balances[msg.sender]):
msg.sender.transfer(balances[msg.sender]);
balances[msg.sender] = 0;
}
```
Expand Down
2 changes: 1 addition & 1 deletion slither/detectors/statements/calls_in_loop.py
Original file line number Diff line number Diff line change
Expand Up @@ -94,7 +94,7 @@ class MultipleCallsInLoop(AbstractDetector):
If one of the destinations has a fallback function that reverts, `bad` will always revert."""
# endregion wiki_exploit_scenario

WIKI_RECOMMENDATION = "Favor [pull over push](https://github.com/ethereum/wiki/wiki/Safety#favor-pull-over-push-for-external-calls) strategy for external calls."
WIKI_RECOMMENDATION = "Favor [pull over push](https://consensysdiligence.github.io/smart-contract-best-practices/development-recommendations/general/external-calls/#favor-pull-over-push-for-external-calls) strategy for external calls."

def _detect(self) -> list[Output]:
""""""
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -28,7 +28,7 @@ class UninitializedLocalVars(AbstractDetector):
contract Uninitialized is Owner{
function withdraw() payable public onlyOwner{
address to;
to.transfer(this.balance)
to.transfer(this.balance);
}
}
```
Expand Down
Loading