build: build ffi only for stable - #1138
Merged
Merged
Conversation
Contributor
There was a problem hiding this comment.
Copilot review overview
🟢 Approval recommended
The workflow consistently excludes FFI only from MSRV checks while retaining stable coverage.
Review effort: Balanced
Findings: None
What changed in this PR
Limits csaf-ffi compilation to stable Rust, allowing UniFFI upgrades without raising the workspace MSRV.
Changes:
- Excludes
csaf-ffifrom MSRV builds, tests, and Clippy. - Applies workspace selection consistently to Cargo commands.
| File | Description |
|---|---|
.github/workflows/build.yml |
Adds conditional FFI exclusion for non-stable matrix jobs. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This enables upgrading uniffi to the next minor version as it would imply a MSRV bump (#731). If we only build FFI on stable, which is fine, this is not a problem anymore.