Ascender 25.6.2 - #233
Ascender 25.6.2#233
Conversation
There was a problem hiding this comment.
🟡 Changes recommended
Key default/pinned versions still appear to be 25.6.1 outside the touched files (e.g., group_vars and offline collection install), so the installer may not actually default to 25.6.2.
Once you've addressed the issues Copilot identified, you can request another Copilot review.
Pull request overview
Updates the installer documentation and default/version references to target Ascender 25.6.2 across prompts, templates, and example configuration files.
Changes:
- Bump Ascender version references from 25.6.1 → 25.6.2 in README badge and upgrade docs.
- Update Ansible config prompting/default fallbacks and deployment template default image_version to 25.6.2.
- Refresh sample platform config files to 25.6.2 for
ASCENDER_VERSIONandASCENDER_OPERATOR_VERSION.
File summaries
| File | Description |
|---|---|
| README.md | Updates the Ascender badge version to 25.6.2. |
| playbooks/roles/config_vars/tasks/ascender.yml | Updates interactive prompt defaults/fallbacks to 25.6.2. |
| playbooks/roles/awx_migrate_ascender/README.md | Updates migration documentation examples to 25.6.2. |
| playbooks/roles/ascender_install/templates/ascender-deployment/additional-spec.yml | Updates default image_version fallback to 25.6.2. |
| playbooks/roles/ascender_install/defaults/main.yml | Updates role default ASCENDER_OPERATOR_VERSION to 25.6.2. |
| docs/installation/rke2/rke2.default.config.yml | Updates example config versions to 25.6.2. |
| docs/installation/k3s/k3s.offline.default.config.yml | Updates offline example config versions to 25.6.2. |
| docs/installation/k3s/k3s.default.config.yml | Updates example config versions to 25.6.2. |
| docs/installation/gke/gke.custom.config.yml | Updates example config versions to 25.6.2. |
| docs/installation/eks/eks.custom.config.yml | Updates example config versions to 25.6.2. |
| docs/installation/dkp/dkp.default.config.yml | Updates example config versions to 25.6.2. |
| docs/installation/aks/aks.custom.config.yml | Updates example config versions to 25.6.2. |
| docs/configuration/upgrading.md | Updates upgrade examples and text references to 25.6.2. |
| default.config.yml | Updates top-level example config version references to 25.6.2. |
Review details
- Files reviewed: 14/14 changed files
- Comments generated: 1
- Review effort level: Lite
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
There was a problem hiding this comment.
🟡 Changes recommended
Offline/online collection installation can still resolve ctrliq.ascender 25.6.1 via collections/requirements.yml, which conflicts with the new 25.6.2 expectation and can break offline installs.
Once you've addressed the issues Copilot identified, you can request another Copilot review.
Review details
- Files reviewed: 16/16 changed files
- Comments generated: 1
- Review effort level: Lite
There was a problem hiding this comment.
🔵 Needs a closer look
The updated offline collection install line in setup.sh still uses unquoted $(dirname $0) expansions, which can break installs when the script path contains spaces or glob characters.
Review details
Suppressed comments (1)
Previously missed (1) — in code that hasn't changed since the last review.
setup.sh:139
$(dirname $0)is unquoted in these paths; if the script is invoked from a location containing spaces or glob characters, word-splitting/globbing can break the offline collection installs. Quote the expansion and the resulting path arguments.
- Files reviewed: 17/17 changed files
- Comments generated: 0 new
- Review effort level: Lite
There was a problem hiding this comment.
🟡 Changes recommended
config_vars.sh introduces installer bootstrap logic that can fail on common environments due to non-portable grep -P usage and unconditional sudo assumptions.
Once you've addressed the issues Copilot identified, you can request another Copilot review.
Review details
Suppressed comments (1)
Previously missed (1) — in code that hasn't changed since the last review.
setup.sh:139
- Paths built with
$(dirname $0)are unquoted, so running the installer from a path containing spaces (or other shell metacharacters) can break offline collection installation. Quote$0and the resulting paths.
- Files reviewed: 18/18 changed files
- Comments generated: 2
- Review effort level: Lite
There was a problem hiding this comment.
🔵 Needs a closer look
config_vars.sh hard-codes sudo during package installation, which can break execution in environments without sudo even when already running as root.
Review details
Suppressed comments (1)
config_vars.sh:27
- The Ansible install step hard-codes
sudo, which will fail on systems wheresudois not installed (common in minimal images) even when the script is already running as root. Consider detecting whether the script is running as root and only usingsudowhen needed (and failing fast with a clear message when neither root nor sudo is available).
if [ $? -ne 0 ]; then
echo "#### INSTALLING ANSIBLE ####"
if [[ "$OS" == "debian" ]]; then
sudo apt-get update -y && sudo apt-get install -y ansible-core
elif [[ "$OS" == "rhel" ]]; then
- Files reviewed: 18/18 changed files
- Comments generated: 0 new
- Review effort level: Lite
No description provided.