Repository navigation
Conversation
Updates to glibc and other parts of the toolchain made this workaround irrelevant. On-behalf-of: SAP philipp.schuster@sap.com Signed-off-by: Philipp Schuster <philipp.schuster@cyberus-technology.de>
On-behalf-of: SAP philipp.schuster@sap.com Signed-off-by: Philipp Schuster <philipp.schuster@cyberus-technology.de>
flake-parts: 2025-04-02T01:38:40+02:00 -> 2026-08-02T01:46:09+02:00 pre-commit-hooks: 2025-05-16T07:19:14+02:00 -> 2026-07-17T13:40:35+02:00 This commit was generated via: nix run github:phip1611/nixos-configs#flake-update-and-commit On-behalf-of: SAP philipp.schuster@sap.com Signed-off-by: Philipp Schuster <philipp.schuster@cyberus-technology.de>
On-behalf-of: SAP philipp.schuster@sap.com Signed-off-by: Philipp Schuster <philipp.schuster@cyberus-technology.de>
phip1611
commented
Aug 17, 2026
On-behalf-of: SAP philipp.schuster@sap.com Signed-off-by: Philipp Schuster <philipp.schuster@cyberus-technology.de>
amphi
reviewed
Aug 17, 2026
Comment on lines
+25
to
+27
| checkInputs = [ catch2_3 ]; | ||
|
|
||
| nativeBuildInputs = [ | ||
| catch2_3 |
Contributor
There was a problem hiding this comment.
Is it really necessary to move catch2_3 into nativeBuildInputs? You explicitly add catch2_3 to the devShell's packages,
Member
Author
There was a problem hiding this comment.
you are right. not needed. nice catch!
amphi
approved these changes
Aug 17, 2026
amphi
left a comment
Contributor
There was a problem hiding this comment.
LGTM. Just left one questions, but I have no hard opinion on that.
On-behalf-of: SAP philipp.schuster@sap.com Signed-off-by: Philipp Schuster <philipp.schuster@cyberus-technology.de>
Keep this access explicit. GCC 15 can otherwise incorrectly diagnose the std::find_if implementation as reading past the object when the array is obtained from the fixed BDA address. On-behalf-of: SAP philipp.schuster@sap.com Signed-off-by: Philipp Schuster <philipp.schuster@cyberus-technology.de>
On-behalf-of: SAP philipp.schuster@sap.com Signed-off-by: Philipp Schuster <philipp.schuster@cyberus-technology.de>
phip1611
enabled auto-merge
August 17, 2026 09:05
github-merge-queue
Bot
removed this pull request from the merge queue due to failed status checks
Aug 17, 2026
Caused by the toolchain update. On-behalf-of: SAP philipp.schuster@sap.com Signed-off-by: Philipp Schuster <philipp.schuster@cyberus-technology.de>
On-behalf-of: SAP philipp.schuster@sap.com Signed-off-by: Philipp Schuster <philipp.schuster@cyberus-technology.de>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Update to nixpkgs @ nixos-26.05.
Part of https://github.com/cobaltcore-dev/cobaltcore/issues/614.