Skip to content

nix: fix printing during nix-build - #14

Merged
phip1611 merged 1 commit into
mainfrom
fix-print
Sep 1, 2026
Merged

phip1611 merged 1 commit into
mainfrom
fix-print

Conversation

@phip1611

@phip1611 phip1611 commented Sep 1, 2026

Copy link
Copy Markdown
Member

The serial driver is printing \r\n by default, which is the correct line break behavior for a terminal. However, in Linux/Nix we only need \n. Since Nix 2.34 (I think, it definitely used to work earlier) nothing is printed during nix build -L if it contains \r\n. Let's fix and make output usable and readable again.

Without

image

With

image

@phip1611 phip1611 self-assigned this Sep 1, 2026
@phip1611
phip1611 requested review from amphi and hertrste September 1, 2026 05:16
@snue

snue commented Sep 1, 2026

Copy link
Copy Markdown
Member

I'm seeing the same thing for some log output on our Hercules CI builds (different project). Strangely it works correctly when executing the nixos tests locally. Thanks for digging into this.

@phip1611
phip1611 added this pull request to the merge queue Sep 1, 2026
Merged via the queue into main with commit 6ec5e0b Sep 1, 2026
11 checks passed
@phip1611
phip1611 deleted the fix-print branch September 1, 2026 07:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants