Repository navigation
Conversation
Member
|
I'm seeing the same thing for some log output on our Hercules CI builds (different project). Strangely it works correctly when executing the nixos tests locally. Thanks for digging into this. |
hertrste
approved these changes
Sep 1, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The serial driver is printing
\r\nby default, which is the correct line break behavior for a terminal. However, in Linux/Nix we only need\n. Since Nix 2.34 (I think, it definitely used to work earlier) nothing is printed duringnix build -Lif it contains\r\n. Let's fix and make output usable and readable again.Without
With