Repository navigation
feat: Shift-aligned drawing, pan through fills, copyable layouts - #54
Merged
Merged
Conversation
- Shift while placing or dragging a line's point snaps it level, upright or to 45 degrees from the previous point and ignores the magnet; Shift while moving a drawing keeps the move level or upright, as TradingView. - Drawing fills are backgrounds the mouse passes through, so dragging inside a channel or zone drawn on a higher timeframe pans the chart instead of moving the drawing. Drawings are grabbed by their lines. - Chart tabs are called layouts in the UI. The + buttons and Window menu open a blank layout or a copy of an open one with its charts, drawings, indicators and settings; a layout's menu offers Duplicate Layout.
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Test plan
npm run typechecknpm test(706 pass), with new tests for background hit-testing, 45-degree alignment and layout copiesnpm run build