Repository navigation
fix: start position shading where price reaches the entry - #62
Merged
Merged
Conversation
The Long and Short Position tools shaded the trade so far from the entry anchor's bar. As in TradingView, the trade now opens at the first bar that trades through the entry price, the stop and target are only checked from there, and an entry price never reached shades nothing and shows no P&L.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The Long and Short Position tools shaded the trade so far from the tool's left edge (the entry anchor's bar). TradingView starts it at the bar where price first touched the entry price. This matches TradingView.
What changed
positionOutcome(packages/meridian-charts/src/drawings/tools.ts) finds the first bar from the entry anchor whose range includes the entry price and returns it asstart. The stop and target are only checked from that bar on, so a stop touched before the entry no longer closes a trade that never opened.Behaviour choices
Testing
npm test(843 tests) and the typecheck pass. Not yet checked by eye in the running app.