chore: remove dead V2 Hasura indexer dependency - #966
Merged
Merged
Conversation
v2-homebase-indexer.w3api.dev is NXDOMAIN (as are all w3api.dev indexer hosts). Every Tezos DAO list load fired a doomed request to it, logged a console error, and pinged trackAppError. No replacement host has ever existed in the repo history, and the legacy app the V2 DAO cards linked to (v2.tezos-homebase.io) bakes in the same dead hosts, so V2 DAO data is unreachable everywhere regardless. Removes client_v2, GET_DAOS_QUERY_V2 (byte-identical to the v1 query, only the host differed), the _V2 env keys, and the dead endpoint's admin secret from env files. Also drops REACT_APP_HASURA_ADMIN_SECRET (v1), which no client ever sent.
✅ Deploy Preview for tezos-homebase ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Removes the app's dependency on
v2-homebase-indexer.w3api.dev, which no longer resolves (NXDOMAIN, along with every otherw3api.devindexer host).Why
c18d5b60).Changes
services.ts: drop theclient_v2request fromgetDAOs(the v1/v3 indexer path is untouched)graphql.ts: deleteclient_v2and its header plumbingqueries.ts: deleteGET_DAOS_QUERY_V2(byte-identical to the v1 query, only the host differed)constants.ts: delete the_V2env keys, plusREACT_APP_HASURA_ADMIN_SECRET(v1), which no client ever sentenv.example,distribution/env.build: remove the corresponding lines (theenv.buildchange alters the next release's BUILDHASH, expected)Not touched: the
registry/treasurytype branches inDAOItem.tsxand theREACT_APP_V2_URLredirect inutils.ts. They are unreachable now (the v3 indexer serves onlylambdaDAOs) but harmless; can go in a later cleanup if desired.Verification
tsc --noEmitcleangrep -r 'client_v2\|HASURA_URL_V2\|HASURA_ADMIN_SECRET' src/returns nothinglambda