Skip to content

Update WorkplaceSearchClientUtil.java - #1423

Closed
ProcopieGabi0112 wants to merge 1 commit into
dadoonet:masterfrom
ProcopieGabi0112:fscrawler-DateFormat
Closed

Update WorkplaceSearchClientUtil.java#1423
ProcopieGabi0112 wants to merge 1 commit into
dadoonet:masterfrom
ProcopieGabi0112:fscrawler-DateFormat

Conversation

@ProcopieGabi0112

Copy link
Copy Markdown

Hi @dadoonet,
My verification tool showed me that it is a pretty serious mistake when using the SimpleDateFormat data type. The error occurs when the SimpleDateFormat variable is changed a certain number of times and its format is not preserved. After researching the error a bit, I found the solution to define the function toRFC3339(Date d) as synchronized.

@dadoonet

dadoonet commented May 9, 2022

Copy link
Copy Markdown
Owner

Thanks for the PR. Don't worry yet about the Github Actions failure. This is because of an outdated library I'm fixing along the way with #1403. Once #1403 is merged, I will ping you to rebase your PR on this latest version.

@dadoonet dadoonet self-assigned this May 9, 2022
@dadoonet dadoonet added the bug For confirmed bugs label May 9, 2022
@dadoonet
dadoonet self-requested a review May 9, 2022 12:38
@dadoonet

Copy link
Copy Markdown
Owner

Hey @ProcopieGabi0112. Could you rebase your branch on master branch?

1 similar comment
@dadoonet

Copy link
Copy Markdown
Owner

Hey @ProcopieGabi0112. Could you rebase your branch on master branch?

@dadoonet dadoonet linked an issue May 10, 2022 that may be closed by this pull request
@ProcopieGabi0112

Copy link
Copy Markdown
Author

Would you like to put all the errors encountered in the main branch?

@dadoonet

Copy link
Copy Markdown
Owner

I first need you to rebase your code on the master branch. Then force push your branch again.
Then GitHub Actions will run again and hopefully will be green.
Then I will be able to review your changes and if ok merge them.

This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug For confirmed bugs

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Small bugs

2 participants