fix(core): 🐛 retain folders after capped deletion query - #2533
fix(core): 🐛 retain folders after capped deletion query#2533newschapmj1 wants to merge 5 commits into
Conversation
newschapmj1
commented
Aug 31, 2026
- Retain folder records when deletion queries return 10,000 entries
- Propagate incomplete deletion status to ancestor folders
- Warn that deletion will continue on a later crawl
- Add regression tests and documentation
- Retain folder records when deletion queries return 10,000 entries - Propagate incomplete deletion status to ancestor folders - Warn that deletion will continue on a later crawl - Add regression tests and documentation
|
Tick the box to add this pull request to the merge queue (same as
|
|
Fix for remove_deleted only reconciles the first 10,000 files in a directory + Orphan files (It is a simple/limited 'Fix'- must rerun crawl to delete file >10K total) |
|
Ha! That's smart. I never thought about the fact that a subsequent run would actually continue cleaning files and folders after 10000 items! Which makes me think that we can probably test this with an integration test:
I'm pasting here the idea but this could be done in another PR. |
dadoonet
left a comment
There was a problem hiding this comment.
LGTM with only a small change to apply.
Also, could you add this as a fix in docs/source/release/3.1.md?
See an example at https://github.com/dadoonet/fscrawler/blob/main/docs/source/release/3.0.md?plain=1#L99
And please add your name at the end of the same file as it was done in https://github.com/dadoonet/fscrawler/blob/main/docs/source/release/3.0.md?plain=1#L142-L143
Thanks!
….java Co-authored-by: David Pilato <david@pilato.fr>
…hub.com/newschapmj1/fscrawler into fix/retain-folder-record-at-query-limit Add Dadoonet changes
|
|
Thanks for looking at this PR so promptly. I will submit a second PR to add a MVN test for this. |


