Skip to content

DAOS-17259 test: Adding gcov to daos build - #16338

Closed
dinghwah wants to merge 197 commits into
masterfrom
dinghwah/DAOS-17259-gtest2
Closed

dinghwah wants to merge 197 commits into
masterfrom
dinghwah/DAOS-17259-gtest2

Conversation

@dinghwah

@dinghwah dinghwah commented May 2, 2025

Copy link
Copy Markdown
Contributor

Adding code-coverage report for daos unit test.

Steps for the author:

  • Commit message follows the guidelines.
  • Appropriate Features or Test-tag pragmas were used.
  • Appropriate Functional Test Stages were run.
  • At least two positive code reviews including at least one code owner from each category referenced in the PR.
  • Testing is complete. If necessary, forced-landing label added and a reason added in a comment.

After all prior steps are complete:

  • Gatekeeper requested (daos-gatekeeper added as a reviewer).

Adding code-coverage report for daos unit test.

Signed-off-by: Ding-Hwa Ho <ding-hwa.ho@hpe.com>
@github-actions

github-actions Bot commented May 2, 2025

Copy link
Copy Markdown

Errors are Unable to load ticket data
https://daosio.atlassian.net/browse/DAOS-17259

dinghwah added 28 commits May 6, 2025 11:52
Signed-off-by: Ding-Hwa Ho <ding-hwa.ho@hpe.com>
Signed-off-by: Ding-Hwa Ho <ding-hwa.ho@hpe.com>
Signed-off-by: Ding-Hwa Ho <ding-hwa.ho@hpe.com>
Signed-off-by: Ding-Hwa Ho <ding-hwa.ho@hpe.com>
Signed-off-by: Ding-Hwa Ho <ding-hwa.ho@hpe.com>
Signed-off-by: Ding-Hwa Ho <ding-hwa.ho@hpe.com>
Signed-off-by: Ding-Hwa Ho <ding-hwa.ho@hpe.com>
Signed-off-by: Ding-Hwa Ho <ding-hwa.ho@hpe.com>
Signed-off-by: Ding-Hwa Ho <ding-hwa.ho@hpe.com>
Signed-off-by: Ding-Hwa Ho <ding-hwa.ho@hpe.com>
Signed-off-by: Ding-Hwa Ho <ding-hwa.ho@hpe.com>
Signed-off-by: Ding-Hwa Ho <ding-hwa.ho@hpe.com>
Signed-off-by: Ding-Hwa Ho <ding-hwa.ho@hpe.com>
Signed-off-by: Ding-Hwa Ho <ding-hwa.ho@hpe.com>
Signed-off-by: Ding-Hwa Ho <ding-hwa.ho@hpe.com>
Signed-off-by: Ding-Hwa Ho <ding-hwa.ho@hpe.com>
Signed-off-by: Ding-Hwa Ho <ding-hwa.ho@hpe.com>
Signed-off-by: Ding-Hwa Ho <ding-hwa.ho@hpe.com>
Signed-off-by: Ding-Hwa Ho <ding-hwa.ho@hpe.com>
Signed-off-by: Ding-Hwa Ho <ding-hwa.ho@hpe.com>
Signed-off-by: Ding-Hwa Ho <ding-hwa.ho@hpe.com>
Signed-off-by: Ding-Hwa Ho <ding-hwa.ho@hpe.com>
Signed-off-by: Ding-Hwa Ho <ding-hwa.ho@hpe.com>
Signed-off-by: Ding-Hwa Ho <ding-hwa.ho@hpe.com>
Signed-off-by: Ding-Hwa Ho <ding-hwa.ho@hpe.com>
Signed-off-by: Ding-Hwa Ho <ding-hwa.ho@hpe.com>
Signed-off-by: Ding-Hwa Ho <ding-hwa.ho@hpe.com>
Signed-off-by: Ding-Hwa Ho <ding-hwa.ho@hpe.com>
@phender

phender commented Dec 1, 2025

Copy link
Copy Markdown
Contributor

@phender

phender commented Dec 1, 2025

Copy link
Copy Markdown
Contributor

Summary of updated test results:

Signed-off-by: Phil Henderson <phillip.henderson@hpe.com>
Signed-off-by: Phil Henderson <phillip.henderson@hpe.com>
@phender
phender marked this pull request as ready for review December 3, 2025 03:57
@phender
phender requested review from a team as code owners December 3, 2025 03:57
@phender

phender commented Dec 3, 2025

Copy link
Copy Markdown
Contributor

Summary of updated test results:

Build 210 (w/o CI_CODE_COVERAGE) passed

@ryon-jensen

ryon-jensen commented Dec 3, 2025 •

Copy link
Copy Markdown
Contributor

What's the expected impact to CI of the code coverage stage? If I understand the Jenkins file changes correctly, the stage will only run once a week, and only for unit tests? Is it a new scheduled run, or extra stage for an already existing scheduled run?
Also, the increase in timeouts applies to all builds, not just when code coverage is enabled, correct?

==>Yes, CI with code coverage will be run weekly with Unit Tests only for now. This is a new schedule run. Functional tests on VM and Hardware will be added when gcov on them are become available.
Yes, the increase in timeouts applies to all builds.

Comment thread utils/docker/Dockerfile.ubuntu Outdated
Comment thread site_scons/site_tools/compiler_setup.py
Signed-off-by: Ding-Hwa Ho <ding-hwa.ho@hpe.com>
phender
phender previously approved these changes Dec 3, 2025
@daosbuild3

Copy link
Copy Markdown
Collaborator

@dinghwah
dinghwah marked this pull request as draft December 5, 2025 22:46
Signed-off-by: Ding-Hwa Ho <ding-hwa.ho@hpe.com>
Comment thread ci/unit/test_main_node.sh

# Generate code coverage report if at least one gcda file was generated
if [ "$WITH_CODE_COVERAGE" = "yes" ]; then
pip install --requirement requirements-code-coverage.txt

Check warning

Code scanning / Scorecard

Pinned-Dependencies Medium test

score is 3: pipCommand not pinned by hash
Click Remediation section below to solve this issue
dinghwah and others added 3 commits December 6, 2025 11:58
Signed-off-by: Ding-Hwa Ho <ding-hwa.ho@hpe.com>
Signed-off-by: Phil Henderson <phillip.henderson@hpe.com>

@daltonbohning daltonbohning left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@phender @dinghwah Do we still need this?

@dinghwah dinghwah closed this Oct 13, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

10 participants