Skip to content

DAOS-17857 pool: container recovery for incremental reintegration - #16810

Closed
Nasf-Fan wants to merge 0 commit into
masterfrom
Nasf-Fan/DAOS-17857
Closed

Nasf-Fan wants to merge 0 commit into
masterfrom
Nasf-Fan/DAOS-17857

Conversation

@Nasf-Fan

@Nasf-Fan Nasf-Fan commented Sep 4, 2025

Copy link
Copy Markdown
Contributor

When incrementally reintegrate some target, before changing the pool map, the PS leader will set pool_prop_recov_cont (a new pool property in RDB) to indicate that the recovering containers for the pool is inprocess. And then the PS leader will send POOL_RECOV_CONT RPC to related target to be reintegrated with the PS leader known containers list for the pool.

During the POOL_RECOV_CONT RPC process, it is possible that someone wants to create or destroy some container(s), then the PS leader will reset the pool_prop_recov_cont in RDB at the beginning of handling related request.

When POOL_RECOV_CONT RPC is replied, the PS leader will know container(s) changes via checking such property. And then it will ask related sponsor to restart the reintegration.

Scuh mechanism will not block container create/destroy during recovering containers. And even if PS leader was switched, it still can work.

For the target being reintegrated, when receives POOL_RECOV_CONT RPC, it will do two cycles scan:

  1. Go through the PS leader offered containers list, for each container, if it does not exist locally, then create it.

  2. Iterate containers in the local VOS pool, for the one that is not in the PS leader offered list, destroy it. For efficiency, we build the containers tree with the PS leader offered list.

Steps for the author:

  • Commit message follows the guidelines.
  • Appropriate Features or Test-tag pragmas were used.
  • Appropriate Functional Test Stages were run.
  • At least two positive code reviews including at least one code owner from each category referenced in the PR.
  • Testing is complete. If necessary, forced-landing label added and a reason added in a comment.

After all prior steps are complete:

  • Gatekeeper requested (daos-gatekeeper added as a reviewer).

@github-actions

github-actions Bot commented Sep 4, 2025 •

Copy link
Copy Markdown

Ticket title is 'Handle container create and destroy for incremental reintegration'
Status is 'In Review'
Labels: '2.8pp'
https://daosio.atlassian.net/browse/DAOS-17857

@Nasf-Fan
Nasf-Fan force-pushed the Nasf-Fan/DAOS-17857 branch from 9e73aef to d0991f9 Compare September 4, 2025 08:55
@daosbuild3

Copy link
Copy Markdown
Collaborator

Test stage Unit Test on EL 8.8 completed with status FAILURE. https://jenkins-3.daos.hpc.amslabs.hpecorp.net/job/daos-stack/job/daos/job/PR-16810/1/display/redirect

@daosbuild3

Copy link
Copy Markdown
Collaborator

Test stage Unit Test bdev with memcheck on EL 8.8 completed with status FAILURE. https://jenkins-3.daos.hpc.amslabs.hpecorp.net/job/daos-stack/job/daos/job/PR-16810/1/display/redirect

@Nasf-Fan
Nasf-Fan force-pushed the Nasf-Fan/DAOS-17857 branch from d0991f9 to 3042144 Compare September 4, 2025 09:20
@daosbuild3

Copy link
Copy Markdown
Collaborator

Test stage Unit Test bdev on EL 8.8 completed with status FAILURE. https://jenkins-3.daos.hpc.amslabs.hpecorp.net/job/daos-stack/job/daos/job/PR-16810/3/display/redirect

@Nasf-Fan
Nasf-Fan force-pushed the Nasf-Fan/DAOS-17857 branch 4 times, most recently from 6e09ce5 to 4ddc327 Compare September 7, 2025 07:47
@daosbuild3

Copy link
Copy Markdown
Collaborator

Test stage Functional on EL 8.8 completed with status FAILURE. https://jenkins-3.daos.hpc.amslabs.hpecorp.net/job/daos-stack/job/daos/job/PR-16810/6/display/redirect

@Nasf-Fan
Nasf-Fan force-pushed the Nasf-Fan/DAOS-17857 branch 3 times, most recently from 4a55fad to 0d6c143 Compare September 10, 2025 01:59
@Nasf-Fan

Copy link
Copy Markdown
Contributor Author

resolve merge conflict.

@Nasf-Fan
Nasf-Fan marked this pull request as ready for review September 10, 2025 02:41
@Nasf-Fan
Nasf-Fan requested review from a team as code owners September 10, 2025 02:41
@Nasf-Fan
Nasf-Fan requested review from a team September 10, 2025 02:41
@Nasf-Fan
Nasf-Fan requested review from a team as code owners September 10, 2025 02:41
@daosbuild3

Copy link
Copy Markdown
Collaborator

Test stage Functional Hardware Medium Verbs Provider MD on SSD completed with status FAILURE. https://jenkins-3.daos.hpc.amslabs.hpecorp.net//job/daos-stack/job/daos/view/change-requests/job/PR-16810/10/execution/node/1540/log

@Nasf-Fan
Nasf-Fan force-pushed the Nasf-Fan/DAOS-17857 branch 2 times, most recently from 435c766 to 4078980 Compare September 11, 2025 05:48
@liuxuezhao
liuxuezhao self-requested a review September 17, 2025 13:33
@Nasf-Fan
Nasf-Fan requested a review from gnailzenh September 17, 2025 13:40
@daosbuild3

Copy link
Copy Markdown
Collaborator

Test stage Functional Hardware Medium Verbs Provider MD on SSD completed with status FAILURE. https://jenkins-3.daos.hpc.amslabs.hpecorp.net//job/daos-stack/job/daos/view/change-requests/job/PR-16810/12/execution/node/1594/log

@Nasf-Fan

Copy link
Copy Markdown
Contributor Author

Rebuild_ec timeout because of DAOS-17657.

@Nasf-Fan

Copy link
Copy Markdown
Contributor Author

Ping reviewers, Thanks!

@Nasf-Fan Nasf-Fan closed this Sep 24, 2025
@Nasf-Fan

Copy link
Copy Markdown
Contributor Author

Something wrong caused the PR closing unexpectedly.

@Nasf-Fan

Copy link
Copy Markdown
Contributor Author

Replaced by #16903

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

2 participants