Skip to content

DAOS-17985 cq: sys_logscan for engine's legacy logs format - #16849

Merged
daltonbohning merged 2 commits into
release/2.6from
grom72/DAOS-17629-2.6
Nov 19, 2025
Merged

DAOS-17985 cq: sys_logscan for engine's legacy logs format#16849
daltonbohning merged 2 commits into
release/2.6from
grom72/DAOS-17629-2.6

Conversation

@grom72

@grom72 grom72 commented Sep 12, 2025 •
edited
Loading

Copy link
Copy Markdown
Contributor

The new log format was proposed and implemented in #16772.
The cart_logparse.py script was modified in #16772 to support the new log format only.
The daos_sys_logscan.py tool is based on cart_logparse.py script and after #16772 landing it will no longer support the old log format.

No tests are required
Backporting the tool to release/2.6 enables analysis of the old logs.

Steps for the author:

  • Commit message follows the guidelines.
  • Appropriate Features or Test-tag pragmas were used.
  • Appropriate Functional Test Stages were run.
  • At least two positive code reviews including at least one code owner from each category referenced in the PR.
  • Testing is complete. If necessary, forced-landing label added and a reason added in a comment.

After all prior steps are complete:

  • Gatekeeper requested (daos-gatekeeper added as a reviewer).

@grom72
DAOS-17629 cq: sys_logscan for backward old logs
1960780 
The new log format was proposed and implemented in #16772.
The cart_logparse.py script was modified in #16772 to support
the new log format only.
The daos_sys_logscan.py tool is based on cart_logparse.py script and
after #16772 landing it will no longer support the old log format.

Backporting the tool to release/2.6 enables analysis of the
old logs.

Doc-only: true

Signed-off-by: Tomasz Gromadzki <tomasz.gromadzki@hpe.com>
@grom72
grom72 requested a review from kccain September 12, 2025 09:02
@grom72
grom72 requested review from a team as code owners September 12, 2025 09:02
@github-actions

github-actions Bot commented Sep 12, 2025 •
edited
Loading

Copy link
Copy Markdown

Ticket title is 'sys_logscan for scanning the engine's legacy log format'
Status is 'Awaiting backport'
Labels: 'scrubbed_2.6.5'
Job should run at elevated priority (1)
https://daosio.atlassian.net/browse/DAOS-17985

@grom72 grom72 mentioned this pull request Sep 12, 2025
Merged
6 tasks done
@grom72 grom72 changed the title DAOS-17629 cq: sys_logscan for backward old logs DAOS-17629 cq: sys_logscan for engine's legacy logs format Sep 15, 2025
@grom72

grom72 commented Sep 15, 2025 •
edited
Loading

Copy link
Copy Markdown
Contributor Author

TheBuild/Run DAOS/NLT tetst (ubuntu) issue has been addressed by https://daosio.atlassian.net/browse/DAOS-17982

@grom72
grom72 requested review from a team and removed request for janekmi and phender September 15, 2025 20:22
@daltonbohning
daltonbohning removed the request for review from a team September 15, 2025 23:44
@daltonbohning

daltonbohning commented Sep 15, 2025

Copy link
Copy Markdown
Contributor

The ticket does not have merge approval for 2.6

@grom72 grom72 changed the title DAOS-17629 cq: sys_logscan for engine's legacy logs format DAOS-17985 cq: sys_logscan for engine's legacy logs format Sep 16, 2025
@grom72

grom72 commented Sep 16, 2025

Copy link
Copy Markdown
Contributor Author

The ticket does not have merge approval for 2.6

New ticket has been created for this task: https://daosio.atlassian.net/browse/DAOS-17985

@daltonbohning

daltonbohning commented Sep 16, 2025

Copy link
Copy Markdown
Contributor

The ticket does not have merge approval for 2.6

New ticket has been created for this task: https://daosio.atlassian.net/browse/DAOS-17985

To get something merged into 2.6, the label request_for_2.6.4 or request_for_2.6.5 should be added to the ticket. Then, the merge approval team periodically polls and approves those. Then, when the ticket has Approved to Merge set we can merge the PR into the corresponding version

@grom72 grom72 added the release-2.6.5 Targeted for release 2.6.5 label Sep 17, 2025
@grom72
grom72 requested a review from a team November 12, 2025 08:26
@daltonbohning

daltonbohning commented Nov 12, 2025

Copy link
Copy Markdown
Contributor

The ticket still does not have merge approval

@daltonbohning
daltonbohning removed the request for review from a team November 12, 2025 16:10
@grom72
Merge remote-tracking branch 'origin/release/2.6' into grom72/DAOS-17…
d795f7d 
…629-2.6

Signed-off-by: Tomasz Gromadzki <tomasz.gromadzki@hpe.com>
Doc-only: true
@github-actions github-actions Bot added the priority Ticket has high priority (automatically managed) label Nov 19, 2025
@grom72
grom72 requested a review from a team November 19, 2025 13:25
@daltonbohning daltonbohning added the forced-landing The PR has known failures or has intentionally reduced testing, but should still be landed. label Nov 19, 2025
@daltonbohning
daltonbohning merged commit c424c43 into release/2.6 Nov 19, 2025
27 checks passed
@daltonbohning
daltonbohning deleted the grom72/DAOS-17629-2.6 branch November 19, 2025 16:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@daltonbohning daltonbohning daltonbohning approved these changes
@kccain kccain kccain approved these changes

Assignees

No one assigned

Labels

forced-landing The PR has known failures or has intentionally reduced testing, but should still be landed. priority Ticket has high priority (automatically managed) release-2.6.5 Targeted for release 2.6.5

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@grom72 @daltonbohning @kccain