Repository navigation
Conversation
1. In theory, it is possible that when exclude some engine, related ULT maybe trying to abort a DTX because of some failure happened during local modification (but related modification has succeeded on remote targets). Related DTX_ABORT RPC has been sent out but not been received or processed by related remote targets. Under such case, the DTX leader is switched because of related engine is exlcuded. And then DTX resync is triggered by new DTX leader who may regard such DTX as committable since all alive targets claim 'PREPARED'. Then the new DTX leader will make different decision that conflict with old DTX leader did. That may cause related DTX to be aborted on some targets but committed on the others, as to data inconsistency among related redundancy group. The new logic forbids to abort DTX from old DTX leader to avoid such inconsistency. 2. During DTX resync, the DTX CHECK RPC should not be sent to the target which UP status and co_in_ver is newer than related DTX version. Because related DTX is either non-exist or removed on the target being reintegrated. 3. Convert dtx_leader_begin() returned failure -DER_TX_RESTART as -DER_INPROGRESS to help client to properly handle related RPC. Signed-off-by: Fan Yong <fan.yong@hpe.com> Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Replicated-object migration enumerates a shard in batches and resumes with the VOS anchors returned by the previous batch. If the leader returned an error (e.g. -DER_REBUILD_DELAY from the rebuild fence right after a failure), migrate_obj_epoch() fell back to a random non-leader replica for the next attempt, and after each successful batch it restored DIOF_TO_LEADER, so one enumeration could hop between replicas. The evtree recx anchor is the last visible extent of the shard that produced it, and evt_iter_probe_find() positions by overlap. Replicas have differently-shaped visible extents (independent aggregation, split/overwrite ordering), so re-probing an anchor on another replica skips the extents up to the next boundary. Those extents were never listed, never migrated, and rebuild still reported success: the rebuilt shard silently lacks committed data (zeroed 64K blocks seen by fio verify in the field and by the REBUILD50 reproducer, runs 20-22). Fix: - obj_list_obj_cb() records the shard that served a non-EOF migration batch in dkey_anchor->da_shard. - migrate_obj_epoch() pins all following batches to that shard with DIOF_TO_SPEC_SHARD instead of returning to the leader or picking another random replica, and keeps retrying in place on -DER_INPROGRESS once pinned. - -DER_REBUILD_DELAY from the leader is retried on the leader (bounded) rather than immediately switching to a non-leader replica. Signed-off-by: Xuezhao Liu <xuezhao.liu@hpe.com> Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
- Captured recovery version is used consistently for CHECK and ABORT. - Busy/error local statuses are preserved. - Post-yield abort checks reject stale authority but allow equal/higher authority—including the regression fix. - Collective local errors propagate, and sole-survivor recovery can commit. - Forced cleanup and version-zero behavior remain intact. Signed-off-by: Liang Zhen <gnailzenh@gmail.com>
|
Errors are component not formatted correctly,Ticket number prefix incorrect,PR title is malformatted. See https://daosio.atlassian.net/wiki/spaces/DC/pages/11133911069/Commit+Comments,Unable to load ticket data |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Steps for the author:
After all prior steps are complete: