fix(key-wallet): construct root_private_key with from_secret_bytes

[kwvg]

Additional Information

• Fix for test(key-wallet): pin scalar reduction paths, refusal of zero scalars and public keys off the curve #1038

• Depends on build!: bump rand to 0.9, getrandom to 0.4, secp256k1 to 0.33, drop the secp256k1 context #1042

• The upgrade to secp256k1 0.33 changed the available APIs and the two pull requests above merged in rapid succession targeting different available APIs, causing dev to currently fail (build).

PR Hygiene · 896700d

• Bots — coderabbitai ✓
• Self-review — post /self-reviewed
• Within your 5 open PRs
• Build green
• Approvals
  • key-wallet (key-wallet/src/derivation_bls_bip32.rs) — approved by ZocoLini

When every box is checked the PR Hygiene check passes and this can merge.

[coderabbitai]

Navigate logical layers of code changes, visualize relationships, and explore their blast radius.

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

⚙️ Run configuration

Configuration used: Repository: dashpay/rust-dashcore/.coderabbit.yaml

Review profile: CHILL

Plan: Advanced

Run ID: d5a7d983-f832-428f-ab46-935ba74647c1

📥 Commits

Reviewing files that changed from the base of the PR and between 859f0ac and 896700d.

📒 Files selected for processing (1)

• key-wallet/src/derivation_bls_bip32.rs

Included review availability: Your plan provides up to 1 included review per hour; 0 remain after this review.

---

📝 Walkthrough

Walkthrough

The test now constructs secp256k1::SecretKey with from_secret_bytes(secret) instead of from_slice(&secret). The test flow and BLS scalar reduction assertion remain unchanged.

Changes

BLS derivation test update

Layer / File(s)	Summary
Secret key construction key-wallet/src/derivation_bls_bip32.rs	The test uses the array-based from_secret_bytes constructor with the existing secret value. Its RootExtendedPrivKey setup and reduction assertion remain unchanged.

Priority: ⬇️ Low

Estimated code review effort: 1 (Trivial) | ~2 minutes

Change: Bug fix

Suggested reviewers: quantumexplorer

Merge Risk: ⚪ Minimal · up to 89670

This updates a test for the newer SecretKey API without changing production behavior; the PR is mergeable.

🚥 Pre-merge checks | ✅ 5

✅ Passed checks (5 passed)

Check name	Status	Explanation
Docstring Coverage	✅ Passed	Docstring coverage is 100.00% which is sufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff. Analyzed 1 functions across 1 files.
Linked Issues check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Title check	✅ Passed	The title clearly identifies the key-wallet change: constructing root_private_key with from_secret_bytes. This matches the pull request objective and the code change.

✨ Finishing Touches

🧪 Generate unit tests (beta)

• Create a new PR

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands.}

[github-actions]

Bots are done — your move: post /self-reviewed.
Full checklist in the description.

[kwvg]

/self-reviewed

[github-actions]

Ready for review — needs QuantumExplorer or ZocoLini or xdustinface.
Full checklist in the description.

[codecov]

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 77.24%. Comparing base (859f0ac) to head (896700d).

Additional details and impacted files

@@            Coverage Diff             @@
##              dev    #1048      +/-   ##
==========================================
+ Coverage   76.02%   77.24%   +1.21%     
==========================================
  Files         255      329      +74     
  Lines       58413    83715   +25302     
==========================================
+ Hits        44410    64664   +20254     
- Misses      14003    19051    +5048     

Flag	Coverage Δ
core	78.24% <ø> (ø)
ffi	50.51% <ø> (-0.01%)	⬇️
rpc	20.00% <ø> (ø)
spv	92.13% <ø> (+<0.01%)	⬆️
wallet	80.04% <100.00%> (?)

Files with missing lines	Coverage Δ
key-wallet/src/derivation_bls_bip32.rs	94.27% <100.00%> (ø)

... and 79 files with indirect coverage changes

[kwvg]

/self-review