set tests for new-cbs-format branch - #2948
Conversation
…ew format Fix other small test failures. Add tests run on pr to new-cbs-format
|
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## new-cbs-format #2948 +/- ##
=================================================
Coverage ? 46.43%
=================================================
Files ? 133
Lines ? 12221
Branches ? 0
=================================================
Hits ? 5675
Misses ? 6546
Partials ? 0
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
Pull request overview
This PR updates CI/test behavior for the new-cbs-format branch by temporarily disabling a handful of infographic-related tests (until the new format is implemented) and cleaning up small lint/test failures so the branch can stay green while infographic work proceeds.
Changes:
- Temporarily skip several infographic-related tests that currently fail under the new CBS format workstream.
- Minor lint/format cleanups (unused imports, whitespace, small readability tweaks).
- Update GitHub Actions workflow to run the Tests workflow on PRs and pushes targeting
new-cbs-format.
Reviewed changes
Copilot reviewed 10 out of 11 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
| tests/test_involved_query.py | Skips an end-to-end involved query test while infographic format work is in progress. |
| tests/test_infographics_utils.py | Skips infographic utility tests pending infographic format updates. |
| tests/test_infographic_api.py | Skips an infographic API test and improves assertion messages for easier debugging when re-enabled. |
| anyway/views/user_system/api.py | Removes an unused import and tidies whitespace. |
| anyway/parsers/junctions.py | Fixes/clarifies CSV parsing helpers and applies formatting improvements. |
| anyway/parsers/cbs/executor.py | Removes unused import and tidies whitespace/trailing lines. |
| anyway/parsers/cbs/dictionary_tables.py | Removes unused pandas import. |
| anyway/models.py | Removes unused ORM-related imports. |
| anyway/marker_bounding_box_query.py | Removes unused typing import. |
| anyway/db_views.py | Whitespace cleanup in a join clause. |
| .github/workflows/Tests.yml | Ensures CI runs on PRs/pushes for new-cbs-format. |
Suppressed comments (1)
tests/test_infographics_utils.py:119
- The skip reason is too generic; include the specific context (migration to the new CBS infographic format / new-cbs-format) so it’s clear when this should be re-enabled.
@unittest.skip("Infographic test disabled")
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
| actual = InvolvedQuery_GB.dictify_double_group_by(data) | ||
| self.assertEqual(actual, expected) | ||
|
|
||
| @pytest.mark.skip(reason="Infographic test disabled") |
There was a problem hiding this comment.
hi, this test is already fixed in the production branch, no need to skip it
There was a problem hiding this comment.
I tried to add it in pr2949 but it failed, so I do not un-skip it in current PR.
| RoadSegments(segment_id=32, road=30, from_km=10.0, to_km=20.0), | ||
| ] | ||
|
|
||
| @unittest.skip("Infographic test disabled") |
| validate(widget["data"]["items"][0], schema) | ||
| assert widget["data"]["text"]["title"] == "כמות פצועים" | ||
|
|
||
| @pytest.mark.skip(reason="Infographic test disabled") |
tkalir
left a comment
tkalir
left a comment
There was a problem hiding this comment.
the test in tests/test_involved_query.py is already fixed, so no need to skip it. good job otherwise, we really should enable tests on this branch.
| actual = InvolvedQuery_GB.dictify_double_group_by(data) | ||
| self.assertEqual(actual, expected) | ||
|
|
||
| @pytest.mark.skip(reason="Infographic test disabled") |
There was a problem hiding this comment.
hi, this test is already fixed in the production branch, no need to skip it
Skip a few infographics tests until infographics are updated to the new format
Fix other small test failures.
Add tests run on pr to new-cbs-format
As I start work on infographics, tests will help to avoid breaking things.