Skip to content

update the embedding_type to embedding_label#546

Open
shixiao-coder wants to merge 2 commits into
datacommonsorg:masterfrom
shixiao-coder:update-embeddin-index-name
Open

update the embedding_type to embedding_label#546
shixiao-coder wants to merge 2 commits into
datacommonsorg:masterfrom
shixiao-coder:update-embeddin-index-name

Conversation

@shixiao-coder

Copy link
Copy Markdown
Contributor

No description provided.

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request renames embedding_type to embedding_label across the ingestion-helper pipeline, including the SQL schema, configuration, routes, utilities, and tests. Feedback on the changes highlights that this renaming is a breaking change for existing deployments configuring EMBEDDING_SPECS via environment variables. It is recommended to support both keys and normalize embedding_type to embedding_label during parsing to maintain backward compatibility.

Important

The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.

Comment thread pipeline/workflow/ingestion-helper/config.py
@codacy-production

codacy-production Bot commented Jun 15, 2026

Copy link
Copy Markdown

Up to standards ✅

🟢 Issues 0 issues

Results:
0 new issues

View in Codacy

🟢 Metrics 0 complexity

Metric Results
Complexity 0

View in Codacy

NEW Get contextual insights on your PRs based on Codacy's metrics, along with PR and Jira context, without leaving GitHub. Enable AI reviewer
TIP This summary will be updated as you push new changes.

@shixiao-coder shixiao-coder requested a review from clincoln8 June 15, 2026 21:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants